Conversation
This fixes a long standing, yet unnoticed, issue where the parser does not handle pure virtual functions properly. (cherry picked from commit e3990365b992bd9f27d5a0c01d26a9b48e050f54)
This reverts commit b1c0224.
don't work
allows finer grain control over volume mixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds:
SoundStream: holds a (currently disabled in lua)SoundActorand info about volume, its target volume, fade rate, if it's playing, and a reference to its ownerSoundStreamSetSoundStreamSet: holds all music-related streams (one base, six more for the layers), info about the global music volume/target volume/fade rate/playing, as well as a bitset of currently active layers.MusicEntry: holds info frommusic.xml(id, filepaths, layer mode, layer fade rate, multiplier, looping) and a list ofMusicLayer.MusicLayer: holds filepaths and a volume multipler.Unfortunately, I have so far been unable to make
SoundActorwork. Calls made with the current binders will either do nothing, do the wrong thing, or crash.