Allow users to change their own email and make password changing easier #616
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated by Django 5.1.9 on 2025-10-01 02:44 | ||
|
|
||
| import users.models.custom_user | ||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("users", "0030_alter_banktransaction_unique_together_and_more"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name="customuser", | ||
| name="oidc_sub", | ||
| field=models.CharField( | ||
| default=users.models.custom_user.get_uuid_str, | ||
| editable=False, | ||
| max_length=255, | ||
| null=True, | ||
| ), | ||
| ), | ||
| ] |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||||||
| # Generated by Django 5.1.9 on 2025-10-01 02:45 | ||||||||||
|
|
||||||||||
| from django.db import migrations | ||||||||||
|
|
||||||||||
| # Note there is a race condition if you allow objects to be created while this migration is running. | ||||||||||
| # Objects created after the AddField and before RunPython will have their original uuid’s overwritten. | ||||||||||
|
Comment on lines
+5
to
+6
There was a problem hiding this comment. [nitpick] The migration comment mentions a race condition but doesn't provide a solution. Consider adding a database transaction or advisory lock during migration to prevent this race condition, or document that migrations should be run during a maintenance window when object creation is disabled.
Suggested change
Contributor
Author
There was a problem hiding this comment. Maybe? This comment is a result of copy pasting directly from Django docs. I was under the impression that migrations are run at server startup before any object creation is possible.
Member
There was a problem hiding this comment. Usually migrations are ran before the service is started. But if you have hundreds of workers running with "internet scale" traffic then the correct way is to first deploy a version that can handle both situations. Then the migration that can run in the background without downtime. Then a new version that has just the new logic. And all of this would happen in a way that first just some traffic, say 10% is sent to the new workers and after verifying it works then the rest of the traffic in few batches. No we are not nowhere near that kind of requirements here :)
Member
There was a problem hiding this comment. Usually migrations are ran before the service is started. But if you have hundreds of workers running with "internet scale" traffic then the correct way is to first deploy a version that can handle both situations. Then the migration that can run in the background without downtime. Then a new version that has just the new logic. And all of this would happen in a way that first just some traffic, say 10% is sent to the new workers and after verifying it works then the rest of the traffic in few batches. No we are not nowhere near that kind of requirements here :) |
||||||||||
| def populate_oidc_sub(apps, schema_editor): | ||||||||||
| CustomUser = apps.get_model("users", "CustomUser") | ||||||||||
| for user in CustomUser.objects.all(): | ||||||||||
| user.oidc_sub = user.email | ||||||||||
| user.save(update_fields=["oidc_sub"]) | ||||||||||
|
|
||||||||||
| def reverse_populate_oidc_sub(apps, schema_editor): | ||||||||||
| # On reverse, we can't meaningfully restore the state since new users | ||||||||||
| # would have UUIDs. Just leave oidc_sub as-is since the field will be | ||||||||||
| # removed by the previous migration's reverse. | ||||||||||
| pass | ||||||||||
|
|
||||||||||
| class Migration(migrations.Migration): | ||||||||||
|
|
||||||||||
| dependencies = [ | ||||||||||
| ("users", "0031_customuser_add_oidc_sub_field"), | ||||||||||
| ] | ||||||||||
|
|
||||||||||
| operations = [ | ||||||||||
| migrations.RunPython(populate_oidc_sub, reverse_populate_oidc_sub) | ||||||||||
| ] | ||||||||||
|
brndd marked this conversation as resolved.
|
||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated by Django 5.1.9 on 2025-10-01 02:45 | ||
|
|
||
| import users.models.custom_user | ||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("users", "0032_customuser_populate_oidc_sub_values"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterField( | ||
| model_name="customuser", | ||
| name="oidc_sub", | ||
| field=models.CharField( | ||
| default=users.models.custom_user.get_uuid_str, | ||
| editable=False, | ||
| max_length=255, | ||
| unique=True, | ||
| ), | ||
| ), | ||
| ] |
Uh oh!
There was an error while loading. Please reload this page.