Skip to content

Add log when marked for deletion email is sent#609

Open
Rikukar wants to merge 3 commits intoTampereHacklab:masterfrom
Rikukar:add-marked-for-deletion-log
Open

Add log when marked for deletion email is sent#609
Rikukar wants to merge 3 commits intoTampereHacklab:masterfrom
Rikukar:add-marked-for-deletion-log

Conversation

@Rikukar
Copy link
Copy Markdown

@Rikukar Rikukar commented Sep 29, 2025

Closes #535

Comment thread users/locale/fi/LC_MESSAGES/django.po Outdated
Comment on lines +666 to +667
"%(value)s ei ole kelvollinen Matrix id. Sen tulee olla muodossa @käyttäjä:"
"esimerkki.org"
"%(value)s ei ole kelvollinen Matrix id. Sen tulee olla muodossa "
"@käyttäjä:esimerkki.org"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this translation change. Adding the log didn't change translations so this should not be changed here

This reverts commit fb6266e.
Copilot AI review requested due to automatic review settings December 3, 2025 09:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds activity logging when a "marked for deletion" email is sent to users. This helps track when users are notified about their account deletion through the user's activity log.

  • Adds a call to instance.log() after the email is sent in the handle_marked_for_deletion signal handler

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread users/signals.py
send_mail(subject, plaintext_content, from_email, to)

# Add to activity log
instance.log("Marked for deletion e-mail sent")
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "e-mail" should be "email" for consistency with the rest of the codebase. Throughout the file, "email" (without hyphen) is used consistently in function names (e.g., send_reset_password_email, send_application_received_email) and log messages (e.g., "sending welcome email", "sending bye bye email").

Suggested change
instance.log("Marked for deletion e-mail sent")
instance.log("Marked for deletion email sent")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add to Member's activity log when Marked For Deletion email is sent

3 participants