fix: resolve SSH tunnel failures with config profiles (#672)#675
Merged
Conversation
48bf7ea to
3d59e7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Includedirective in SSH config parser — hosts defined in included files (e.g.,~/.ssh/config.d/*, OrbStack, Lima) now appear in the Config Host picker. Recursive parsing with glob patterns, circular include protection, and depth limiting.effectiveSSHConfig(profile:)instead of reading inlinesshConfig.enabled, preventing port leaks when SSH profiles are used.%d,%h,%u,%r,%%) inIdentityFile/IdentityAgentpaths — previously stored literally, causing "file not found" errors.Hostentries — entries likeHost prod dev stagingare now excluded from the picker to prevent DNS resolution failures.Closes #672
Test plan
~/.ssh/configwithInclude config.d/*shows hosts from included files in Config Host pickerIdentityFile %d/.ssh/keyresolves to correct pathHost prod stagingentries don't appear in pickerSSHConfigParserTestsandSSHPathUtilitiesTests(26 new test cases)