Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final UX consistency pass before the audit closes out. Two small categories of fixes.
Empty state polish
GroupManagementViewempty state gains a "Create Group" button so the user does not need to find the toolbar+buttonTagManagementViewsame: "Create Tag" button on the empty stateQueryEditorView"No Results" gets a description: "The query returned no rows." Matches the description-included shape used by every other empty state (Tables, Indexes, FKs, History)VoiceOver custom actions
Audit revealed three rows whose only deletion path was a trailing swipe gesture, which VoiceOver users cannot trigger. Added
.accessibilityAction(named:)so those deletions show up in the standard "Custom Actions" rotor:DataBrowserViewrow → "Delete row"GroupManagementViewrow → "Delete group"TagManagementViewrow → "Delete tag" (only when not a preset tag)ConnectionListViewrows already expose Edit / Duplicate / Delete via context menu, which VoiceOver picks up automatically; no extra accessibility action needed there.QueryHistoryViewuses.onDeletewhich provides the standard accessibility delete action for free.Test plan