Skip to content

fix(quick-switcher): use queryHistoryManager after queryHistoryStorage was removed from AppServices#1179

Merged
datlechin merged 1 commit intomainfrom
fix/quick-switcher-query-history-manager-migration
May 10, 2026
Merged

fix(quick-switcher): use queryHistoryManager after queryHistoryStorage was removed from AppServices#1179
datlechin merged 1 commit intomainfrom
fix/quick-switcher-query-history-manager-migration

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

Second hotfix for PR #1176. Removing queryHistoryStorage from AppServices and migrating its callers caught the MCP tool sites and HistoryDataProvider, but missed QuickSwitcherViewModel.loadItems which still read services.queryHistoryStorage.fetchHistory(...).

Compiler error:

QuickSwitcherViewModel.swift:113:45 Value of type 'AppServices' has no member 'queryHistoryStorage'

One-line migration: services.queryHistoryStorage.fetchHistory(...) -> services.queryHistoryManager.fetchHistory(...). Manager's signature now accepts the same parameters Storage did (extended in PR #1178), so the call site is unchanged otherwise.

Test plan

  • Build succeeds.
  • Quick switcher (Cmd+K or whatever the binding is) lists recent query history alongside tables/views/databases.
  • swiftlint --strict clean.

@datlechin datlechin merged commit 8b17873 into main May 10, 2026
2 checks passed
@datlechin datlechin deleted the fix/quick-switcher-query-history-manager-migration branch May 10, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant