Skip to content

chore(parity): add validate:parity script and fix compatibility contract violations#541

Open
felippepestana wants to merge 1 commit intoSynkraAI:mainfrom
felippepestana:main
Open

chore(parity): add validate:parity script and fix compatibility contract violations#541
felippepestana wants to merge 1 commit intoSynkraAI:mainfrom
felippepestana:main

Conversation

@felippepestana
Copy link

@felippepestana felippepestana commented Mar 2, 2026

Summary

  • Add npm run validate:parity script to package.json
  • Add IDE compatibility status table to docs/ide-integration.md (Works/Limited per contract)
  • Generate 12 Codex skills in .codex/skills/ via codex-skills-sync

Problem

node .aios-core/infrastructure/scripts/validate-parity.js was not registered as an npm script, and the AIOS 4.0.4 compatibility contract had two failing checks:

  • codex-integration: .codex/skills/ directory missing
  • codex-skills: skills not generated
  • Docs matrix: docs/ide-integration.md lacked the status table expected by the validator

Validation

✅ Parity validation passed

All contract checks now pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added 12 new AI specialist personas: Analyst, Architect, Data Engineer, Developer, DevOps Manager, Master Orchestrator, Product Manager, Product Owner, QA Specialist, Scrum Master, Squad Creator, and UX Design Expert. Each includes dedicated activation protocols and command sets for specialized workflows.
  • Documentation

    • Updated IDE integration guide with AIOS compatibility status for supported platforms.

…act violations

- Add npm run validate:parity script to package.json
- Add IDE compatibility status table to docs/ide-integration.md (Works/Limited)
- Generate 12 Codex skills in .codex/skills/ via codex-skills-sync

Fixes: codex-integration, codex-skills, and docs matrix checks.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 2, 2026

@felippepestana is attempting to deploy a commit to the Pedro Valério Lopez's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Walkthrough

This PR introduces twelve new AIOS persona skill definitions as SKILL.md documentation files, each specifying activation protocols, starter commands, and operational constraints. It also updates IDE compatibility documentation and adds a npm script for parity validation.

Changes

Cohort / File(s) Summary
AIOS Skills Documentation
.codex/skills/aios-analyst/SKILL.md, .codex/skills/aios-architect/SKILL.md, .codex/skills/aios-data-engineer/SKILL.md, .codex/skills/aios-dev/SKILL.md, .codex/skills/aios-devops/SKILL.md, .codex/skills/aios-master/SKILL.md, .codex/skills/aios-pm/SKILL.md, .codex/skills/aios-po/SKILL.md, .codex/skills/aios-qa/SKILL.md, .codex/skills/aios-sm/SKILL.md, .codex/skills/aios-squad-creator/SKILL.md, .codex/skills/aios-ux-design-expert/SKILL.md
Added twelve persona skill definitions, each defining activation metadata, usage context, protocol steps (load source of truth, adopt persona, generate greeting, maintain persona), starter commands (e.g., \*help, \create-, \*research, etc.), and non-negotiables enforcing constitution adherence and dependency-based execution.
Documentation & Configuration
docs/ide-integration.md, package.json
Added IDE compatibility status table showing AIOS support across development environments; introduced validate:parity npm script invoking .aios-core/infrastructure/scripts/validate-parity.js.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #160: Adds Codex skills synchronization and validation logic that processes and validates the SKILL.md files introduced in this PR.
  • PR #170: Introduces the validate-parity.js validation script that is referenced by the new validate:parity npm script added in this PR.

Suggested labels

documentation, agents, tools, ci/cd, area: devops, area: docs

Suggested reviewers

  • oalanicolas
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary changes: adding a validate:parity script and addressing compatibility contract violations through skill generation and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to aios-core! Thanks for your first pull request.

What happens next?

  1. Automated checks will run on your PR
  2. A maintainer will review your changes
  3. Once approved, we'll merge your contribution!

PR Checklist:

Thanks for contributing!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 9

🧹 Nitpick comments (5)
.codex/skills/aios-devops/SKILL.md (1)

17-26: Align Starter Commands with the 3–6 command convention.

This section currently has 8 commands. Suggest keeping core commands in this block and moving lower-frequency operations to a secondary list.

Based on learnings: agent shortcut response must show 3-6 main commands.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-devops/SKILL.md around lines 17 - 26, The Starter
Commands list in the "Starter Commands" section contains eight items and must be
reduced to 3–6 core commands; pick the most essential commands (for example keep
`*help`, `*detect-repo`, `*pre-push`, `*create-pr`, `*release`) and move the
remaining lower-frequency items (`*version-check`, `*push`, `*configure-ci`)
into a new secondary list labeled "Additional Commands" or "Advanced/Optional
Commands"; update the agent shortcut response guidance to reference only the 3–6
main commands so the quick-help output shows a concise set of primary actions.
.codex/skills/aios-squad-creator/SKILL.md (1)

17-26: Starter command list is too long for a shortcut surface.

Recommend limiting this section to 3–6 main commands and placing the rest in an “Additional/Advanced Commands” section for consistency across skills.

Based on learnings: agent shortcut response must show 3-6 main commands.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-squad-creator/SKILL.md around lines 17 - 26, The Starter
Commands list is too long for the shortcut surface; in SKILL.md reduce the
visible Starter Commands to 3–6 primary entries (for example keep `*help`,
`*create-squad`, `*design-squad`, plus 0–2 others you deem highest priority) and
move the remaining bullets (`*validate-squad`, `*list-squads`, `*migrate-squad`,
`*analyze-squad`, `*extend-squad`) under a new "Additional/Advanced Commands"
section; ensure the new primary list is the one used by any agent shortcut
display so the shortcut response shows only 3–6 main commands.
.codex/skills/aios-dev/SKILL.md (1)

17-26: Reduce “Starter Commands” to the top 3–6 commands.

Current list is broad for a starter surface. Recommend keeping primary entry points only and moving advanced flows (*execute-subtask, *track-attempt, etc.) under an extended section.

Based on learnings: agent shortcut response must show 3-6 main commands.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-dev/SKILL.md around lines 17 - 26, Reduce the “Starter
Commands” list to a compact 3–6 primary entry points: keep the most common
commands such as *help, *develop, *develop-yolo, *rollback, and *build-resume
(choose 3–6 that best fit your UX), and move the remaining entries
(*execute-subtask, *verify-subtask, *track-attempt, etc.) into a new “Advanced
Commands” or “Extended Flows” section below; update the SKILL.md block so the
top section only lists the selected primary commands and the advanced section
contains the other, less frequently used commands.
.codex/skills/aios-architect/SKILL.md (1)

17-26: Narrow the “Starter Commands” set to 3–6 primary entries.

This currently reads as a full command catalog. For activator consistency, keep only the main entry commands here and move the rest to a follow-up section.

Based on learnings: agent shortcut response must show 3-6 main commands.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-architect/SKILL.md around lines 17 - 26, Update the
"Starter Commands" section in SKILL.md to present only 3–6 primary activator
commands (e.g., keep `*help`, one high-level design command like
`*create-full-stack-architecture`, one analysis/guide command like
`*analyze-project-structure` or `*guide`) and remove the remaining commands
(`*create-backend-architecture`, `*create-front-end-architecture`,
`*document-project`, `*research`, etc.) from that list; move those removed items
into a new follow-up subsection titled "Additional Commands" or "Full Command
Catalog" below the starter list so the file retains the full command set but the
starter section shows a concise 3–6 item set.
.codex/skills/aios-po/SKILL.md (1)

17-26: Trim Starter Commands to a 3–6 “main commands” subset.

This list currently has 8 entries; consider keeping core commands here and moving the rest to a secondary section (e.g., “Additional Commands”) to match the shortcut contract consistently.

Based on learnings: agent shortcut response must show 3-6 main commands.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-po/SKILL.md around lines 17 - 26, Trim the Starter
Commands list in .codex/skills/aios-po/SKILL.md to a 3–6 main commands subset by
keeping the core shortcuts (*help, *backlog-add, *backlog-review,
*validate-story-draft, *close-story) and moving the remaining entries
(*backlog-summary, *stories-index, *execute-checklist-po) into a new "Additional
Commands" section below; update the section header and order so the top-level
shortcut response shows only the chosen 5 main commands and the rest are
documented as secondary utilities.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.codex/skills/aios-data-engineer/SKILL.md:
- Line 3: The YAML frontmatter description value is truncated ("modelin...");
replace the incomplete description field in
.codex/skills/aios-data-engineer/SKILL.md so it matches the full, intended text
(use the complete "When To Use" wording as the source of truth) — update the
description: line starting with description: to contain the full sentence about
database design, schema architecture, Supabase configuration, RLS policies,
migrations, query optimization, and data modeling (remove the ellipsis and
ensure the entire phrase is included).

In @.codex/skills/aios-master/SKILL.md:
- Line 3: The YAML frontmatter's description value for the AIOS skill is
truncated ("AIOS Master Orchestrator & Framework Developer (Orion) ...
orchest..."); update the YAML "description" key value (the line starting with
description: containing "AIOS Master Orchestrator & Framework Developer
(Orion)") to restore the full, untruncated sentence/summary for the skill so it
no longer ends with "orchest...". Ensure punctuation and spacing remain valid
YAML (quote the string if it contains colons or special characters).
- Line 6: The top-level heading in SKILL.md currently duplicates the word "AIOS"
("AIOS AIOS Master Orchestrator & Framework Developer Activator"); update the
heading to remove the redundant word so it reads "AIOS Master Orchestrator &
Framework Developer Activator" (edit the line beginning with "# AIOS AIOS Master
Orchestrator & Framework Developer Activator").

In @.codex/skills/aios-pm/SKILL.md:
- Line 3: The YAML key 'description' and the "When To Use" section contain
truncated text ending with "scop..."; update both places in SKILL.md to restore
the full phrase (e.g., "scope management") and complete any cut-off sentences so
the description reads fully (for example: "Product Manager (Morgan). Use for PRD
creation (greenfield and brownfield), epic creation and management, product
strategy and vision, feature prioritization (MoSCoW, RICE), roadmap planning,
and scope management.") and ensure the "When To Use" paragraph likewise replaces
"scop..." with the complete intended wording.

In @.codex/skills/aios-qa/SKILL.md:
- Line 3: The YAML `description` field and the "When To Use" section are
truncated (contain `requ...` and `teams c...`); update the
`.codex/skills/aios-qa/SKILL.md` content so the full descriptive text is
restored for the YAML `description` key and for the "When To Use" section (and
the second occurrence referenced as 9-9), replacing the ellipses with the full
intended sentences so the description and guidance are complete and readable.

In @.codex/skills/aios-sm/SKILL.md:
- Line 3: The description YAML field "description" currently ends with
"backlo..." and the "When To Use" section ends with "and lo..."; fix both
truncations by replacing the truncated fragments with the full words/phrases:
update "backlo..." to "backlog" and update "and lo..." to "and long‑term
planning" (or another full intended phrase), ensuring the YAML description line
reads like "Scrum Master (River). Use for user story creation from PRD, story
validation and completeness checking, acceptance criteria definition, story
refinement, sprint planning, backlog" (or extend to a full sentence), and ensure
the "When To Use" section text is restored to a complete sentence ending with
"and long‑term planning".

In @.codex/skills/aios-ux-design-expert/SKILL.md:
- Around line 17-18: Update the SKILL.md starter commands to match the agent
definition in ux-design-expert.md by replacing the single `*help` entry with the
recommended set of commands (e.g., `*help`, `*research`, `*wireframe`, `*audit`,
`*tokenize`, `*guide`) and add a one-line description for each; ensure the
command names and brief descriptions exactly mirror the actions defined in
ux-design-expert.md so the skill exposes the 3–6 main shortcuts required by the
learnings requirement.

In `@docs/ide-integration.md`:
- Around line 18-28: The "AIOS Compatibility Status" table is missing four IDE
rows (Windsurf, Cline, Roo Code, Trae) and mismatches the "Quick Comparison
Table" which lists 9 IDEs; update the table under the "AIOS Compatibility
Status" heading to include rows for Windsurf, Cline, Roo Code, and Trae with
their correct Status values, and reconcile the inconsistency for "Codex CLI" by
either adding Codex CLI to the Quick Comparison Table or removing Codex CLI from
this compatibility table so both tables list the same set of IDEs.

In `@package.json`:
- Line 39: The "validate:parity" npm script references a missing file
(.aios-core/infrastructure/scripts/validate-parity.js); either remove the
"validate:parity" entry from package.json or create the referenced script file.
If you want parity validation behavior, add a new script file at
.aios-core/infrastructure/scripts/validate-parity.js implementing the intended
validation (or re-export/alias the existing validate-agents.js logic), then
ensure package.json's "validate:parity" points to that file; if the script is
unnecessary, simply delete the "validate:parity" script entry from package.json.

---

Nitpick comments:
In @.codex/skills/aios-architect/SKILL.md:
- Around line 17-26: Update the "Starter Commands" section in SKILL.md to
present only 3–6 primary activator commands (e.g., keep `*help`, one high-level
design command like `*create-full-stack-architecture`, one analysis/guide
command like `*analyze-project-structure` or `*guide`) and remove the remaining
commands (`*create-backend-architecture`, `*create-front-end-architecture`,
`*document-project`, `*research`, etc.) from that list; move those removed items
into a new follow-up subsection titled "Additional Commands" or "Full Command
Catalog" below the starter list so the file retains the full command set but the
starter section shows a concise 3–6 item set.

In @.codex/skills/aios-dev/SKILL.md:
- Around line 17-26: Reduce the “Starter Commands” list to a compact 3–6 primary
entry points: keep the most common commands such as *help, *develop,
*develop-yolo, *rollback, and *build-resume (choose 3–6 that best fit your UX),
and move the remaining entries (*execute-subtask, *verify-subtask,
*track-attempt, etc.) into a new “Advanced Commands” or “Extended Flows” section
below; update the SKILL.md block so the top section only lists the selected
primary commands and the advanced section contains the other, less frequently
used commands.

In @.codex/skills/aios-devops/SKILL.md:
- Around line 17-26: The Starter Commands list in the "Starter Commands" section
contains eight items and must be reduced to 3–6 core commands; pick the most
essential commands (for example keep `*help`, `*detect-repo`, `*pre-push`,
`*create-pr`, `*release`) and move the remaining lower-frequency items
(`*version-check`, `*push`, `*configure-ci`) into a new secondary list labeled
"Additional Commands" or "Advanced/Optional Commands"; update the agent shortcut
response guidance to reference only the 3–6 main commands so the quick-help
output shows a concise set of primary actions.

In @.codex/skills/aios-po/SKILL.md:
- Around line 17-26: Trim the Starter Commands list in
.codex/skills/aios-po/SKILL.md to a 3–6 main commands subset by keeping the core
shortcuts (*help, *backlog-add, *backlog-review, *validate-story-draft,
*close-story) and moving the remaining entries (*backlog-summary,
*stories-index, *execute-checklist-po) into a new "Additional Commands" section
below; update the section header and order so the top-level shortcut response
shows only the chosen 5 main commands and the rest are documented as secondary
utilities.

In @.codex/skills/aios-squad-creator/SKILL.md:
- Around line 17-26: The Starter Commands list is too long for the shortcut
surface; in SKILL.md reduce the visible Starter Commands to 3–6 primary entries
(for example keep `*help`, `*create-squad`, `*design-squad`, plus 0–2 others you
deem highest priority) and move the remaining bullets (`*validate-squad`,
`*list-squads`, `*migrate-squad`, `*analyze-squad`, `*extend-squad`) under a new
"Additional/Advanced Commands" section; ensure the new primary list is the one
used by any agent shortcut display so the shortcut response shows only 3–6 main
commands.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a67cd50 and 517b989.

📒 Files selected for processing (14)
  • .codex/skills/aios-analyst/SKILL.md
  • .codex/skills/aios-architect/SKILL.md
  • .codex/skills/aios-data-engineer/SKILL.md
  • .codex/skills/aios-dev/SKILL.md
  • .codex/skills/aios-devops/SKILL.md
  • .codex/skills/aios-master/SKILL.md
  • .codex/skills/aios-pm/SKILL.md
  • .codex/skills/aios-po/SKILL.md
  • .codex/skills/aios-qa/SKILL.md
  • .codex/skills/aios-sm/SKILL.md
  • .codex/skills/aios-squad-creator/SKILL.md
  • .codex/skills/aios-ux-design-expert/SKILL.md
  • docs/ide-integration.md
  • package.json

@@ -0,0 +1,30 @@
---
name: aios-data-engineer
description: Database Architect & Operations Engineer (Dara). Use for database design, schema architecture, Supabase configuration, RLS policies, migrations, query optimization, data modelin...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Truncated description in YAML frontmatter.

The description field ends with modelin..., indicating truncation. Note that the "When To Use" section (line 9) appears to have the complete text—consider aligning the frontmatter description accordingly.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-data-engineer/SKILL.md at line 3, The YAML frontmatter
description value is truncated ("modelin..."); replace the incomplete
description field in .codex/skills/aios-data-engineer/SKILL.md so it matches the
full, intended text (use the complete "When To Use" wording as the source of
truth) — update the description: line starting with description: to contain the
full sentence about database design, schema architecture, Supabase
configuration, RLS policies, migrations, query optimization, and data modeling
(remove the ellipsis and ensure the entire phrase is included).

@@ -0,0 +1,30 @@
---
name: aios-master
description: AIOS Master Orchestrator & Framework Developer (Orion). Use when you need comprehensive expertise across all domains, framework component creation/modification, workflow orchest...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Truncated description text.

The YAML description (line 3) ends with orchest..., indicating truncation. Please restore the complete description.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-master/SKILL.md at line 3, The YAML frontmatter's
description value for the AIOS skill is truncated ("AIOS Master Orchestrator &
Framework Developer (Orion) ... orchest..."); update the YAML "description" key
value (the line starting with description: containing "AIOS Master Orchestrator
& Framework Developer (Orion)") to restore the full, untruncated
sentence/summary for the skill so it no longer ends with "orchest...". Ensure
punctuation and spacing remain valid YAML (quote the string if it contains
colons or special characters).

description: AIOS Master Orchestrator & Framework Developer (Orion). Use when you need comprehensive expertise across all domains, framework component creation/modification, workflow orchest...
---

# AIOS AIOS Master Orchestrator & Framework Developer Activator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Redundant "AIOS" in heading.

The heading reads # AIOS AIOS Master Orchestrator & Framework Developer Activator with a duplicate "AIOS" prefix.

📝 Suggested fix
-# AIOS AIOS Master Orchestrator & Framework Developer Activator
+# AIOS Master Orchestrator & Framework Developer Activator
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# AIOS AIOS Master Orchestrator & Framework Developer Activator
# AIOS Master Orchestrator & Framework Developer Activator
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-master/SKILL.md at line 6, The top-level heading in
SKILL.md currently duplicates the word "AIOS" ("AIOS AIOS Master Orchestrator &
Framework Developer Activator"); update the heading to remove the redundant word
so it reads "AIOS Master Orchestrator & Framework Developer Activator" (edit the
line beginning with "# AIOS AIOS Master Orchestrator & Framework Developer
Activator").

@@ -0,0 +1,30 @@
---
name: aios-pm
description: Product Manager (Morgan). Use for PRD creation (greenfield and brownfield), epic creation and management, product strategy and vision, feature prioritization (MoSCoW, RICE), roa...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Truncated text in description fields.

Both the YAML description (line 3) and the "When To Use" section (line 9) end with scop..., indicating truncated content. The full text should be restored—likely intended to be "scope management" or similar.

Also applies to: 9-9

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-pm/SKILL.md at line 3, The YAML key 'description' and the
"When To Use" section contain truncated text ending with "scop..."; update both
places in SKILL.md to restore the full phrase (e.g., "scope management") and
complete any cut-off sentences so the description reads fully (for example:
"Product Manager (Morgan). Use for PRD creation (greenfield and brownfield),
epic creation and management, product strategy and vision, feature
prioritization (MoSCoW, RICE), roadmap planning, and scope management.") and
ensure the "When To Use" paragraph likewise replaces "scop..." with the complete
intended wording.

@@ -0,0 +1,30 @@
---
name: aios-qa
description: Test Architect & Quality Advisor (Quinn). Use for comprehensive test architecture review, quality gate decisions, and code improvement. Provides thorough analysis including requ...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Truncated text in description fields.

The YAML description (line 3) ends with requ... and the "When To Use" section (line 9) ends with teams c.... The complete text should be restored.

Also applies to: 9-9

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-qa/SKILL.md at line 3, The YAML `description` field and
the "When To Use" section are truncated (contain `requ...` and `teams c...`);
update the `.codex/skills/aios-qa/SKILL.md` content so the full descriptive text
is restored for the YAML `description` key and for the "When To Use" section
(and the second occurrence referenced as 9-9), replacing the ellipses with the
full intended sentences so the description and guidance are complete and
readable.

@@ -0,0 +1,26 @@
---
name: aios-sm
description: Scrum Master (River). Use for user story creation from PRD, story validation and completeness checking, acceptance criteria definition, story refinement, sprint planning, backlo...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Truncated text in description fields.

The YAML description (line 3) ends with backlo... and the "When To Use" section (line 9) ends with and lo.... These appear to be cut off mid-word (likely "backlog"). Please restore the complete text.

Also applies to: 9-9

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-sm/SKILL.md at line 3, The description YAML field
"description" currently ends with "backlo..." and the "When To Use" section ends
with "and lo..."; fix both truncations by replacing the truncated fragments with
the full words/phrases: update "backlo..." to "backlog" and update "and lo..."
to "and long‑term planning" (or another full intended phrase), ensuring the YAML
description line reads like "Scrum Master (River). Use for user story creation
from PRD, story validation and completeness checking, acceptance criteria
definition, story refinement, sprint planning, backlog" (or extend to a full
sentence), and ensure the "When To Use" section text is restored to a complete
sentence ending with "and long‑term planning".

Comment on lines +17 to +18
## Starter Commands
- `*help` - List available commands
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# First, let's understand repo structure
echo "=== Repository structure ==="
git ls-files | head -30

# Find SKILL.md files
echo ""
echo "=== Finding SKILL.md files ==="
fd -t f "SKILL.md" 

# Find agent definition files
echo ""
echo "=== Finding agent definition files ==="
fd -t f "\.md$" | grep -i "agent" | head -20

Repository: SynkraAI/aios-core

Length of output: 2241


🏁 Script executed:

#!/bin/bash

# Search specifically for .codex directory
echo "=== Searching for .codex directory ==="
find . -type d -name ".codex" 2>/dev/null

# List all files in .codex/skills if it exists
echo ""
echo "=== Files in .codex/skills ==="
find . -path "*/.codex/skills/*" -type f 2>/dev/null | sort

# Check the specific file from the review
echo ""
echo "=== Content of aios-ux-design-expert/SKILL.md (lines 1-50) ==="
cat ".codex/skills/aios-ux-design-expert/SKILL.md" 2>/dev/null | head -50

# Compare with another skill file
echo ""
echo "=== Other SKILL.md files for comparison ==="
find . -path "*/.codex/skills/*/SKILL.md" -type f 2>/dev/null | head -3

Repository: SynkraAI/aios-core

Length of output: 1875


🏁 Script executed:

#!/bin/bash

# Compare starter commands across several SKILL.md files
echo "=== Comparing Starter Commands across SKILL.md files ==="

for file in ./.codex/skills/aios-dev/SKILL.md ./.codex/skills/aios-architect/SKILL.md ./.codex/skills/aios-analyst/SKILL.md ./.codex/skills/aios-ux-design-expert/SKILL.md; do
  echo ""
  echo "--- $(basename $(dirname $file)) ---"
  cat "$file" | sed -n '/## Starter Commands/,/^## /p' | head -20
done

# Check the agent definition file
echo ""
echo "=== Checking ux-design-expert agent definition ==="
if [ -f ".aios-core/development/agents/ux-design-expert.md" ]; then
  head -100 ".aios-core/development/agents/ux-design-expert.md"
else
  echo "File not found at .aios-core/development/agents/ux-design-expert.md"
fi

# Also check the codex agents fallback
echo ""
echo "=== Checking codex agents fallback ==="
ls -la .codex/agents/ 2>/dev/null | head -20

Repository: SynkraAI/aios-core

Length of output: 7359


Add missing starter commands to match agent definition.

The SKILL.md file lists only *help as a starter command, whereas the underlying agent definition (ux-design-expert.md) defines 8+ commands across three phases (*research, *wireframe, *audit, *consolidate, *tokenize, *setup, etc.). This falls short of the learnings requirement for agent shortcuts to expose 3–6 main commands. Compare with peer skills: aios-dev lists 8 commands, aios-architect lists 8, aios-analyst lists 6.

Recommended starter commands from agent definition:
## Starter Commands
- `*help` - Show all available commands with descriptions
- `*research` - Perform user research and analysis
- `*wireframe` - Create wireframes and design mockups
- `*audit` - Audit codebase for design system compliance
- `*tokenize` - Extract and organize design tokens
- `*guide` - Show comprehensive usage guide for this agent
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.codex/skills/aios-ux-design-expert/SKILL.md around lines 17 - 18, Update
the SKILL.md starter commands to match the agent definition in
ux-design-expert.md by replacing the single `*help` entry with the recommended
set of commands (e.g., `*help`, `*research`, `*wireframe`, `*audit`,
`*tokenize`, `*guide`) and add a one-line description for each; ensure the
command names and brief descriptions exactly mirror the actions defined in
ux-design-expert.md so the skill exposes the 3–6 main shortcuts required by the
learnings requirement.

Comment on lines +18 to +28
### AIOS Compatibility Status

| IDE | Status |
|-----|--------|
| Claude Code | Works |
| Gemini CLI | Works |
| Codex CLI | Limited |
| Cursor | Limited |
| GitHub Copilot | Limited |
| AntiGravity | Limited |

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Incomplete IDE coverage in compatibility status table.

The new status table lists 6 IDEs, but the document mentions "9 AI-powered development platforms" (line 16), and the Quick Comparison Table (line 31) includes 9 IDEs. Missing status entries for: Windsurf, Cline, Roo Code, and Trae.

Additionally, Codex CLI appears here but is absent from the Quick Comparison Table below—if it's a supported platform, consider adding it there as well.

📝 Suggested addition to complete the table
 | IDE | Status |
 |-----|--------|
 | Claude Code | Works |
 | Gemini CLI | Works |
 | Codex CLI | Limited |
 | Cursor | Limited |
 | GitHub Copilot | Limited |
 | AntiGravity | Limited |
+| Windsurf | Limited |
+| Cline | Limited |
+| Roo Code | Limited |
+| Trae | Limited |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### AIOS Compatibility Status
| IDE | Status |
|-----|--------|
| Claude Code | Works |
| Gemini CLI | Works |
| Codex CLI | Limited |
| Cursor | Limited |
| GitHub Copilot | Limited |
| AntiGravity | Limited |
### AIOS Compatibility Status
| IDE | Status |
|-----|--------|
| Claude Code | Works |
| Gemini CLI | Works |
| Codex CLI | Limited |
| Cursor | Limited |
| GitHub Copilot | Limited |
| AntiGravity | Limited |
| Windsurf | Limited |
| Cline | Limited |
| Roo Code | Limited |
| Trae | Limited |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/ide-integration.md` around lines 18 - 28, The "AIOS Compatibility
Status" table is missing four IDE rows (Windsurf, Cline, Roo Code, Trae) and
mismatches the "Quick Comparison Table" which lists 9 IDEs; update the table
under the "AIOS Compatibility Status" heading to include rows for Windsurf,
Cline, Roo Code, and Trae with their correct Status values, and reconcile the
inconsistency for "Codex CLI" by either adding Codex CLI to the Quick Comparison
Table or removing Codex CLI from this compatibility table so both tables list
the same set of IDEs.

"validate:manifest": "node scripts/validate-manifest.js",
"validate:structure": "node .aios-core/infrastructure/scripts/source-tree-guardian/index.js",
"validate:agents": "node .aios-core/infrastructure/scripts/validate-agents.js",
"validate:parity": "node .aios-core/infrastructure/scripts/validate-parity.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Check if the specific path exists
echo "=== Checking .aios-core/infrastructure/scripts/ ==="
if [ -d ".aios-core/infrastructure/scripts/" ]; then
  echo "Directory exists."
  ls -la ".aios-core/infrastructure/scripts/" 2>/dev/null | head -20
else
  echo "Directory does not exist."
fi

# Search for validate-parity.js anywhere in the repo
echo -e "\n=== Searching for validate-parity.js ==="
fd -t f "validate-parity" . 2>/dev/null

# Check package.json for the line in question
echo -e "\n=== Checking package.json around line 39 ==="
if [ -f "package.json" ]; then
  sed -n '35,45p' package.json
else
  echo "package.json not found"
fi

Repository: SynkraAI/aios-core

Length of output: 2502


The validate:parity script references a non-existent file.

The npm script at line 39 points to .aios-core/infrastructure/scripts/validate-parity.js, but this file does not exist in the repository. The directory contains validate-agents.js and many other scripts, but validate-parity.js is missing. Running npm run validate:parity will fail. Either create the script file or remove this entry from package.json.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 39, The "validate:parity" npm script references a
missing file (.aios-core/infrastructure/scripts/validate-parity.js); either
remove the "validate:parity" entry from package.json or create the referenced
script file. If you want parity validation behavior, add a new script file at
.aios-core/infrastructure/scripts/validate-parity.js implementing the intended
validation (or re-export/alias the existing validate-agents.js logic), then
ensure package.json's "validate:parity" points to that file; if the script is
unnecessary, simply delete the "validate:parity" script entry from package.json.

Copy link
Contributor

@nikolasdehor nikolasdehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review da PR #541: chore(parity): add validate:parity script and fix compatibility contract violations

Resumo

Esta PR propoe adicionar o script validate:parity ao package.json, uma tabela de compatibilidade ao docs/ide-integration.md, e 12 arquivos SKILL.md em .codex/skills/.


Problema critico: PR completamente redundante

O fork esta 84 commits atras da branch main. Todas as alteracoes propostas nesta PR ja existem no upstream com conteudo identico ou superior:

Arquivo/Mudanca Status na main atual
12x .codex/skills/*/SKILL.md Ja existem com conteudo identico
package.jsonvalidate:parity Ja existe na main
.aios-core/infrastructure/scripts/validate-parity.js Ja existe na main
docs/ide-integration.md — tabela de status main ja tem uma "Quick Status Matrix (AIOS 4.2.11)" muito mais completa (5 colunas, workarounds, 6 IDEs)

O fork foi criado a partir de um estado antigo do repo (antes dos PRs que adicionaram essas features). O autor re-criou o mesmo trabalho que ja foi mergeado upstream.

Se esta PR fosse mergeada, causaria conflito massivo de merge (84 commits de divergencia) e potencialmente regrediria o docs/ide-integration.md para uma versao mais antiga e simplificada.


Problemas adicionais (caso a PR fosse relevante)

1. Tabela incompleta e inconsistente em docs/ide-integration.md

A tabela proposta tem apenas 2 colunas (IDE, Status) e faltam IDEs que ja aparecem na documentacao atual (Windsurf, Cline, Roo Code, Trae). A versao atual da main ja resolveu isso com uma matriz unica e unificada.

2. Textos truncados em multiplos SKILL.md

Varias descricoes YAML estao cortadas com reticencias — isso ja existe no upstream com o mesmo bug do codex-skills-sync, mas nao e algo que deveria ser perpetuado:

  • aios-data-engineer/SKILL.md: "...data modelin..."
  • aios-master/SKILL.md: "...orchest..."
  • aios-pm/SKILL.md: "...scop..."
  • aios-qa/SKILL.md: "...requ..." e "...teams c..."

3. aios-master/SKILL.md — Titulo duplicado

# AIOS AIOS Master Orchestrator & Framework Developer Activator

"AIOS" aparece duas vezes.

4. Branch de origem: main do fork

A PR vem da branch main do fork (felippepestana:main), nao de uma feature branch. Isso impede o autor de manter o fork sincronizado e nao segue o padrao conventional de feat/, fix/, chore/ branches.


Veredicto: REQUEST_CHANGES

Esta PR deve ser fechada por ser completamente redundante. Todo o conteudo ja existe na branch main upstream.

Recomendacao ao autor:

  1. Sincronize seu fork: git fetch upstream && git reset --hard upstream/main
  2. Se houver trabalho novo a contribuir, crie uma feature branch a partir da main atualizada
  3. Verifique o estado atual do repo antes de propor mudancas

Revisado por @nikolasdehor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants