Update default limits to more sensible values#120
Open
loevgaard wants to merge 1 commit intoSylius:masterfrom
Open
Update default limits to more sensible values#120loevgaard wants to merge 1 commit intoSylius:masterfrom
loevgaard wants to merge 1 commit intoSylius:masterfrom
Conversation
Contributor
|
What do you think of having rather a config for defining all grids at once ? Like: sylius_grid:
default_grids_limits: [50, 100, 200]And then the individual grid definition would override this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been annoyed by these default limits multiple times - maybe others have as well? :-)