feat(nds): expose firmware language setting for melonDS#1095
Open
oscaruiz wants to merge 2 commits intoSwordfish90:masterfrom
Open
feat(nds): expose firmware language setting for melonDS#1095oscaruiz wants to merge 2 commits intoSwordfish90:masterfrom
oscaruiz wants to merge 2 commits intoSwordfish90:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exposes
melonds_firmware_languageas anExposedSettingin the NDSsystem configuration, allowing users to select the firmware language for
melonDS directly from the in-game settings menu.
Closes #496
Why
PAL Nintendo DS ROMs support multiple languages but there was no way
to select them in Lemuroid. The core option already existed in melonDS
— it just wasn't exposed in the UI.
Changes
GameSystem.kt: addedExposedSettingformelonds_firmware_languagein the melonDS
SystemCoreConfigwith seven language options.strings.xml: added label and value strings. The label includesa "restart required" note since melonDS reads the language at boot.
Notes
No UI or game lifecycle code was modified. The setting surfaces
automatically through the existing
ExposedSettingmechanism.