🐛 add zeros to complete pncc frames instead of ignoring the last …#71
Open
falihery-ran wants to merge 1 commit intoSuperKogito:masterfrom
Open
🐛 add zeros to complete pncc frames instead of ignoring the last …#71falihery-ran wants to merge 1 commit intoSuperKogito:masterfrom
falihery-ran wants to merge 1 commit intoSuperKogito:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
PNCC: When calling the function framing inside spafe/utils/preprocessing.py, we lose the last frame if it is shorter than others instead having it filled by zeros.
To Reproduce
With the code below, we lose the last frame containing the value 20 instead of having it followed by 0 0.
Result before fix
frames: [[ 1. 2. 3. 4.]
[ 4. 5. 6. 7.]
[ 7. 8. 9. 10.]
[10. 11. 12. 13.]
[13. 14. 15. 16.]
[16. 17. 18. 19.]], frames_len: 4
Result after fix
frames: [[ 1. 2. 3. 4.]
[ 4. 5. 6. 7.]
[ 7. 8. 9. 10.]
[10. 11. 12. 13.]
[13. 14. 15. 16.]
[16. 17. 18. 19.]
[19. 20. 0. 0.]], frames_len: 4