This repository was archived by the owner on Jan 19, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Some minor ideas and suggestions #12
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,11 @@ _Note: All of the properties inside of `gddPlayoutOptions` are optional._ | |
| /** The default / suggested layer to play on */ | ||
| "layer"?: number | ||
|
|
||
| /** A list of the commands supported by the template, can be displayed as buttons */ | ||
| "commands": ["play", "next", "stop", "update", "(custom invokes)"] | ||
| /** A template should support "play" and "stop" as a minimum. Some templates are not meant to be updated when already */ | ||
| /** played, so they shall not support "update". Some templates support invoke comands like "show", "hide", "showOvertime" */ | ||
| /** or anything else. These commands can be used to render (or enable/disable) buttons in the UI. */ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should be aiming to support existing templates in this specification, so I don't think this is the way to go. A larger question though is: "how the templates should work"? |
||
| }, | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the option to pick color+alpha would be good 👍 , but because it changes the underlying data type, it should be a separate gddType. I suggest we create a separate PR for this.