SB-I212: Added fallback for overlay#528
Merged
pallakartheekreddy merged 6 commits intoSunbird-Knowlg:release-7.7.0from Sep 12, 2025
Merged
SB-I212: Added fallback for overlay#528pallakartheekreddy merged 6 commits intoSunbird-Knowlg:release-7.7.0from
pallakartheekreddy merged 6 commits intoSunbird-Knowlg:release-7.7.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds fallback values for overlay menu labels when the AppLables object is undefined or missing specific properties. The changes ensure that "Replay", "Teacher's note", and "Exit" text is always displayed even when the internationalization labels are not available.
- Added fallback text for three menu items in the overlay interface
- Used logical OR operators and template literals to provide default English text
- Ensures consistent user experience when localization data is incomplete
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| menu.html | Added fallback "Replay" text for the replay button when AppLables.replay is undefined |
| overlay.js | Added fallback "Teacher's note" text for stage instructions when AppLables.instructions is undefined |
| plugin.js | Added fallback "Exit" text for the genie/exit button when AppLables.exit is undefined |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
player/public/coreplugins/org.ekstep.overlay-1.0/renderer/controller/overlay.js
Outdated
Show resolved
Hide resolved
player/public/coreplugins/org.ekstep.genie-1.0/renderer/plugin.js
Outdated
Show resolved
Hide resolved
pallakartheekreddy
approved these changes
Sep 11, 2025
…troller/overlay.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pallakartheekreddy
merged commit 3e4ca3c
into
Sunbird-Knowlg:release-7.7.0
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fallback for Replay, Teacher's Note and Exit