Deployment workflow updates#6540
Open
vfalconisumo wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
Collaborator
This comment was marked as resolved.
This comment was marked as resolved.
Implement changes from Kim's review: #6540 (comment) The concern about multiline commit messages breaking `$GITHUB_OUTPUT` was correct, but the recommended fix assumed the entire commit message needs to be preserved. In practice, the first line of the commit message provides enough context when tracking changes in our site repo in Pantheon, so instead I've used `head` to cut the commit message down to the first line.
Collaborator
Author
|
@kimsauce I've implemented the recommended fixes, and added a note in my commit about why I didn't use exact solution Claude provided. Also, I tested this in a dummy repository sending the JSON to a webhook listener. I've attached some screenshots showing the successful handling of multiple lines and special characters in commit messages: Probably best merged during US business hours, just in case we missed something. |
kimsauce
approved these changes
Apr 28, 2026
Collaborator
kimsauce
left a comment
There was a problem hiding this comment.
Thank you so much, @vfalconisumo ! Looks clean & great to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose of this pull request
This pull request updates the production deployment workflow in two ways:
haythem/public-ipAction with an equivalent shell script. We're not sure of the how or the why, buthaythem/public-iphas been returning intermittent errors which have broken pipeline runs for a few weeks.Risk
I've tested the new scripts in a sandbox and am confident they work. However, if the changes do introduce workflow errors, publishing docs content will be impacted.
If the workflow fails as a result of these changes, revert this PR to restore the workflow.
Select the type of change
Ticket (if applicable)