Skip to content

Deployment workflow updates#6540

Open
vfalconisumo wants to merge 5 commits intomainfrom
workflow-updates-2026-04-03
Open

Deployment workflow updates#6540
vfalconisumo wants to merge 5 commits intomainfrom
workflow-updates-2026-04-03

Conversation

@vfalconisumo
Copy link
Copy Markdown
Collaborator

Purpose of this pull request

This pull request updates the production deployment workflow in two ways:

  1. Replaces the haythem/public-ip Action with an equivalent shell script. We're not sure of the how or the why, but haythem/public-ip has been returning intermittent errors which have broken pipeline runs for a few weeks.
  2. Clarifies the triggering reason sent to Jenkins, making the message more human-readable.

Risk

I've tested the new scripts in a sandbox and am confident they work. However, if the changes do introduce workflow errors, publishing docs content will be impacted.

If the workflow fails as a result of these changes, revert this PR to restore the workflow.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

  1. Runner IP replacement: Asana
  2. Triggering reason clarity: Asana

@vfalconisumo vfalconisumo requested a review from kimsauce as a code owner April 3, 2026 19:59
@cla-bot cla-bot Bot added the cla-signed Contributor approved, listed in .clabot file label Apr 3, 2026
@jpipkin1
Copy link
Copy Markdown
Contributor

jpipkin1 commented Apr 3, 2026

@kimsauce, could you review this PR? It fixes a problem that we've been having in the deployment pipeline lately (see here).

@kimsauce
Copy link
Copy Markdown
Collaborator

kimsauce commented Apr 3, 2026

@kimsauce, could you review this PR? It fixes a problem that we've been having in the deployment pipeline lately (see here).

@jpipkin1 sure thing! Thank you for the additional background. 👍

@kimsauce

This comment was marked as resolved.

Implement changes from Kim's review: #6540 (comment)

The concern about multiline commit messages breaking `$GITHUB_OUTPUT` was correct, but the recommended fix assumed the entire commit message needs to be preserved. In practice, the first line of the commit message provides enough context when tracking changes in our site repo in Pantheon, so instead I've used `head` to cut the commit message down to the first line.
@vfalconisumo
Copy link
Copy Markdown
Collaborator Author

@kimsauce I've implemented the recommended fixes, and added a note in my commit about why I didn't use exact solution Claude provided.

Also, I tested this in a dummy repository sending the JSON to a webhook listener. I've attached some screenshots showing the successful handling of multiple lines and special characters in commit messages:
dummy-repo-commit
webhook-results

Probably best merged during US business hours, just in case we missed something.

@kimsauce kimsauce added the doc:site tech Site/tool maintenance, dependencies, updates label Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @vfalconisumo ! Looks clean & great to me.

@kimsauce kimsauce enabled auto-merge May 8, 2026 00:44
@kimsauce kimsauce added this pull request to the merge queue May 8, 2026
@kimsauce kimsauce removed this pull request from the merge queue due to a manual request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file doc:site tech Site/tool maintenance, dependencies, updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants