Fix: hasChildren infinite loop + WCAG critical accessibility fixes#13
Open
camlambert2000 wants to merge 2 commits intomainfrom
Open
Fix: hasChildren infinite loop + WCAG critical accessibility fixes#13camlambert2000 wants to merge 2 commits intomainfrom
camlambert2000 wants to merge 2 commits intomainfrom
Conversation
… loop Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
camlambert2000
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1: hasChildren prefer-not-to-say infinite loop
Fixes infinite loop where selecting 'Prefer not to say' on the children question set hasChildren to null, causing routeToNextProfileQuestion to re-ask the same question indefinitely.
Change: choice 3 now maps to false (mirrors existing lgbtq handler pattern). Test added to verify progression past the gate.
Fix 2: WCAG critical accessibility fixes for screen reader users
Three critical accessibility fixes in ChatWidget.tsx. All attribute-only changes, no visual impact, no routing or safeguarding changes.
73 tests passing, 0 errors.