Gate bug fix, immigration status flow, LGBTQ+ specialist, consent gate removal (PR #7 redo)#11
Closed
camlambert2000 wants to merge 12 commits intomainfrom
Closed
Gate bug fix, immigration status flow, LGBTQ+ specialist, consent gate removal (PR #7 redo)#11camlambert2000 wants to merge 12 commits intomainfrom
camlambert2000 wants to merge 12 commits intomainfrom
Conversation
…health/ethnicity questions Adds SPECIAL_CATEGORY_CONSENT gate that fires before asking LGBTQ+, ethnicity, or health questions. Declining consent sets lgbtq=false and marks health/ethnicity as declined_consent, skipping those questions entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replaces the 4-option publicFunds question with a 10-option immigration status question that derives publicFunds automatically. Maps statuses like asylum_seeker and undocumented to No, british_irish and refugee to Yes, pre-settled to Not sure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a user identifies as LGBTQ+, they are now asked whether they'd prefer referral to an LGBTQ+ specialist service. Adds LGBTQ_SPECIALIST_ASK gate, lgbtqSpecialist session field, and no-local-service fallback phrase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…and gate fix tests Adds 10 tests covering: immigration status derives correct publicFunds values (5 tests), LGBTQ+ Yes routes to specialist follow-up, consent decline skips LGBTQ question, and null-check gate fix prevents re-triggering for lgbtq:false, hasChildren:false, and specialCategoryConsent:false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ove dead code
- B5_PROFILE_LGBTQ "Prefer not to say" now sets lgbtq=false instead of null,
preventing infinite loop where routeToNextProfileQuestion re-triggers the question
- LGBTQ_SPECIALIST_ASK now writes to lgbtqServicePreference ('Specialist first' /
'Show both') instead of the unused lgbtqSpecialist field, making it compatible
with serviceMatcher.getSpecialistOrgs()
- Removed lgbtqSpecialist from SessionState and createSession (dead field)
- Removed LGBTQ_SPECIALIST_NO_LOCAL phrasebank entries (never referenced)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
PR #11 is up with the same 12 commits from the original PR #7, rebased clean onto main. 63 tests passing, 0 lint errors. The early flow gates work (preferred name, access location, return user, housing options involvement) will be a separate PR once this one is through. The lint fixes PR is also ready for review when you're back — 21 errors resolved from the tightened rules you added. No rush on any of it. |
Collaborator
|
Closing — this work is already on main via PRs 9 and 10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-raised as requested. Same commits as original PR #7, reviewed and updated to address all feedback. No new changes.
🤖 Generated with Claude Code