Merged
Conversation
- re-use ephemeris colors from AstroCalc (and add colors for Uranus, Neptune) - Allow longer periods in GUI (up to 250 years for now) - increase max isolated trails count to 9
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
alex-w
approved these changes
Apr 19, 2026
Member
Author
|
As usual, I have run RESET_UI_TO_QT5.sh. I have now compiled with Qt5.12, worked without a change. The CIs also work. What did you observe? |
Member
Don’t worry, I said it before complete compiling the code. It’s a fail report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The planet trails are all shown in the same color. This PR re-uses the colors which are already used for the similarly-applied planet ephemeris curves from Astrocalc to draw the planet trails in distinct colors. (Colors for Uranus and Neptune have been added.)
In addition, duration for trails (years) can now be configured in the GUI.
In addition, the distinct curves limit has been raised from 5 to 9.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: