Skip to content

Colored trails#4881

Merged
gzotti merged 2 commits intomasterfrom
colored_trails
Apr 19, 2026
Merged

Colored trails#4881
gzotti merged 2 commits intomasterfrom
colored_trails

Conversation

@gzotti
Copy link
Copy Markdown
Member

@gzotti gzotti commented Apr 19, 2026

Description

The planet trails are all shown in the same color. This PR re-uses the colors which are already used for the similarly-applied planet ephemeris curves from Astrocalc to draw the planet trails in distinct colors. (Colors for Uranus and Neptune have been added.)

In addition, duration for trails (years) can now be configured in the GUI.

In addition, the distinct curves limit has been raised from 5 to 9.

Fixes # (issue)

Screenshots (if appropriate):

stellarium-050

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 11
  • Graphics Card: Geforce

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gzotti added 2 commits April 19, 2026 19:50
- re-use ephemeris colors from AstroCalc (and add colors for Uranus, Neptune)
- Allow longer periods in GUI (up to 250 years for now)
- increase max isolated trails count to 9
@gzotti gzotti added this to the 26.2 milestone Apr 19, 2026
@gzotti gzotti self-assigned this Apr 19, 2026
@gzotti gzotti added importance: medium A bit annoying, minor miscalculation, but no crash purpose: didactic Issues, pull requests and proposals with didactic purposes purpose: planetarium Issues, pull requests and proposals for using in real planetariums labels Apr 19, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Solar System Apr 19, 2026
@github-actions github-actions Bot requested review from 10110111 and alex-w April 19, 2026 18:47
@github-actions
Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

alex-w

This comment was marked as outdated.

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Apr 19, 2026

As usual, I have run RESET_UI_TO_QT5.sh. I have now compiled with Qt5.12, worked without a change. The CIs also work. What did you observe?

@alex-w
Copy link
Copy Markdown
Member

alex-w commented Apr 19, 2026

As usual, I have run RESET_UI_TO_QT5.sh. I have now compiled with Qt5.12, worked without a change. The CIs also work. What did you observe?

Don’t worry, I said it before complete compiling the code. It’s a fail report

@gzotti gzotti merged commit fe172bb into master Apr 19, 2026
28 checks passed
@gzotti gzotti deleted the colored_trails branch April 19, 2026 19:14
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Solar System Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

importance: medium A bit annoying, minor miscalculation, but no crash purpose: didactic Issues, pull requests and proposals with didactic purposes purpose: planetarium Issues, pull requests and proposals for using in real planetariums

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants