[BugFix] Fix projection loss in MV rewrite due to shared mutable state. (backport #69063)#69188
Open
mergify[bot] wants to merge 1 commit intobranch-4.0from
Open
[BugFix] Fix projection loss in MV rewrite due to shared mutable state. (backport #69063)#69188mergify[bot] wants to merge 1 commit intobranch-4.0from
mergify[bot] wants to merge 1 commit intobranch-4.0from
Conversation
…e. (#69063) Signed-off-by: edwinhzhang <[email protected]> (cherry picked from commit ced50d7)
24 tasks
Contributor
Author
🧪 CI InsightsHere's what we observed from your CI run for c132f14. 🟢 All jobs passed!But CI Insights is watching 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Side effect issue caused by Java object reference passing. The QueryMaterializationContext stores a reference to the original object. During the Stage1 optimization process, SeparateProjectRule directly modifies the projection field of this original object, causing Stage2 to retrieve an already-modified object, which leads to the loss of the projection field.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #69063 done by [Mergify](https://mergify.com).