chore: Replaces string interpolation with structured logging - PhysicalConnection & PhysicalBridge#2929
Merged
mgravell merged 2 commits intoStackExchange:mainfrom Jul 24, 2025
Conversation
…alConnection & PhysicalBridge Replaces string interpolation with structured logging Migrates logging calls from string interpolation to structured logging using LoggerMessage attributes. This improves performance by avoiding string allocation and enables better log analysis through structured data. Adds new logging extension methods for PhysicalBridge operations including connection establishment, failures, dead socket detection, and resurrection attempts.
Introduces dedicated LoggerMessage attributes for PhysicalConnection operations to improve logging performance and consistency. Replaces string interpolation and manual log calls with strongly-typed logging methods that provide better compile-time safety and runtime performance through source generation. Covers connection lifecycle events including endpoint validation, connection attempts, TLS configuration, socket operations, and connection establishment.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #2899
Introduces dedicated LoggerMessage attributes for PhysicalConnection operations to improve logging performance and consistency.
Replaces string interpolation and manual log calls with strongly-typed logging methods that provide better compile-time safety and runtime performance through source generation.
Covers connection lifecycle events including endpoint validation, connection attempts, TLS configuration, socket operations, and connection establishment.