modules/packet: fix tx capture when using hw offloads#586
Merged
Conversation
The set_tx_offload_metadata() function clears all the offloads in the mbuf, so it should be done before setting the Tx sink metadata.
There was a problem hiding this comment.
Pull request overview
This PR fixes Tx capture metadata being cleared when hardware checksum/TCP segmentation offloads are enabled in the DPDK packet stack path. Since set_tx_offload_metadata() overwrites rte_mbuf::ol_flags, it must run before setting the Tx sink dynflag/metadata used by capture.
Changes:
- Move
mbuf_tx_sink_set()to occur afterset_tx_offload_metadata()innet_interface::handle_tx(). - Preserve Tx sink metadata for capture even when Tx offload metadata is applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set_tx_offload_metadata() function clears all the offloads in the mbuf, so it should be done before setting the Tx sink metadata.