Skip to content

Removing gil for numba (mostly in peak detection) #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removing gil for numba (mostly in peak detection) #4309

yger wants to merge 1 commit into from
+15 −15

Conversation

@yger
Copy link
Collaborator

@yger yger commented Jan 9, 2026

Could speedup numba function

@yger yger added enhancement New feature or request sortingcomponents Related to sortingcomponents module labels Jan 9, 2026
@samuelgarcia
Copy link
Member

samuelgarcia commented Jan 9, 2026

Good catch.
Indeed big speedup when using threads.
So maybe we could switch back to threads by default for windows no ?

@yger
Copy link
Collaborator Author

yger commented Jan 9, 2026

I guess yes, for windows we should use threads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@samuelgarcia samuelgarcia

@yger yger

Labels

enhancement New feature or request sortingcomponents Related to sortingcomponents module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yger @samuelgarcia