Skip to content

Fix get_probe set_probe annotations propagation #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alejoe91 merged 1 commit into from
Jan 20, 2026
Merged

Fix get_probe set_probe annotations propagation #4300

alejoe91 merged 1 commit into from
Jan 20, 2026
+7 −1

Conversation

@chrishalcrow
Copy link
Member

@chrishalcrow chrishalcrow commented Jan 7, 2026

Probe annotations were not being propagated when we set and get probes.

This was due to:

  • a bug in set_probe where probes_info was only being set for in_place mode
  • we never re-attached the probes_info to the probes when we get_probes

@alejoe91 alejoe91 added the core Changes to core module label Jan 7, 2026
@chrishalcrow chrishalcrow added the bug Something isn't working label Jan 20, 2026
@alejoe91 alejoe91 changed the title Fix get_probe set_probe annotations propogation Fix get_probe set_probe annotations propagation Jan 20, 2026
@alejoe91 alejoe91 merged commit 7399610 into SpikeInterface:main Jan 20, 2026
15 checks passed
@chrishalcrow chrishalcrow deleted the fix-attach-probe-annotation branch January 20, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelgarcia samuelgarcia samuelgarcia approved these changes

@alejoe91 alejoe91 alejoe91 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working core Changes to core module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrishalcrow @samuelgarcia @alejoe91