Add field attributes (aliases, ignore, rename) for derive FormatArgs#2
Open
smith61 wants to merge 2 commits intoSpaceManiac:masterfrom
Open
Add field attributes (aliases, ignore, rename) for derive FormatArgs#2smith61 wants to merge 2 commits intoSpaceManiac:masterfrom
smith61 wants to merge 2 commits intoSpaceManiac:masterfrom
Conversation
Contributor
Author
|
Ideas for possible future attributes:
|
Owner
|
Thanks for the PR! These features look really useful, and mirror serde's quite nicely. Due to the size of the changes and the complex code, it might take me some time to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for field attributes when using
#derive(FormatArgs)on a struct. Adding these attributes allows for hiding of internal fields, or providing backwards compatible names for given fields.aliases- Comma separated list of alternative names for the provided field.ignore- If set, field is hidden from format strings.rename- Overrides the default name for a given field.This pull request also refactored most of the generation code. While the generated code mostly matches, regular structs now also support indices similar to tuple structs and tuple structs can have named fields using the added attributes. This was done to unify the code and make it agnostic of struct type.