Skip to content

MCP-449 Clean up dependencies from the Docker image#373

Merged
nquinquenel merged 4 commits intomasterfrom
task/nq/cleanup-dependencies-for-cve
Apr 28, 2026
Merged

MCP-449 Clean up dependencies from the Docker image#373
nquinquenel merged 4 commits intomasterfrom
task/nq/cleanup-dependencies-for-cve

Conversation

@nquinquenel
Copy link
Copy Markdown
Member

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Clean up dependencies from the Docker image MCP-449 Clean up dependencies from the Docker image Apr 28, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 28, 2026

MCP-449

@nquinquenel nquinquenel marked this pull request as ready for review April 28, 2026 11:13
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 28, 2026

Summary

This PR removes unused build dependencies from the production Docker image and test containers to reduce attack surface and image size. Specifically:

  • Removed git from the Dockerfile and test container setup (previously noted as required by proxied servers, but no longer needed)
  • Removed npm (bundled with nodejs, making it redundant; the image only needs the nodejs runtime)
  • Kept nodejs as a required runtime dependency

All references in documentation and test setup are updated consistently to reflect this cleanup.

What reviewers should know

Where to focus:

  • Start with the Dockerfile changes—these are the core of the PR
  • Check test files to confirm the package removals don't break test infrastructure
  • Verify the README documentation now accurately describes remaining dependencies

Key considerations for reviewers:

  • Confirm that git and npm are genuinely unused (search code for any invocations if uncertain)
  • The branch name suggests this relates to a CVE—verify that removing these packages addresses the security concern without breaking functionality
  • Image size/layer changes are a side benefit but not the primary goal here

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as resolved.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@nquinquenel nquinquenel merged commit b84c2d3 into master Apr 28, 2026
14 checks passed
@nquinquenel nquinquenel deleted the task/nq/cleanup-dependencies-for-cve branch April 28, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants