Skip to content

MCP-441 Use generic Java version#365

Merged
sophio-japharidze-sonarsource merged 1 commit intomasterfrom
use_generic_java_version
Apr 27, 2026
Merged

MCP-441 Use generic Java version#365
sophio-japharidze-sonarsource merged 1 commit intomasterfrom
use_generic_java_version

Conversation

@sophio-japharidze-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Use generic Java version MCP-441 Use generic Java version Apr 27, 2026
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 27, 2026

Summary

Updates the Dockerfile's base Java image from a specific patch version (21.0.10_7) to the generic Java 21 tag, allowing automatic updates to the latest Java 21 patch releases.

This single-line change makes the container image more flexible by automatically pulling newer Java 21 patches and security updates, rather than being locked to a specific point-in-time version.

What reviewers should know

What changed:

  • Dockerfile line 1: Java base image tag simplified from eclipse-temurin:21.0.10_7-jdk-alpine to eclipse-temurin:21-jdk-alpine

Key implications for review:

  • The image will now auto-update with Java security patches instead of requiring manual Dockerfile updates
  • Build reproducibility changes slightly — builds will use the latest 21.x patch rather than a fixed version
  • Verify this aligns with your release/deployment strategy (e.g., whether CI/CD pins image digests separately)

Start reading: Just the Dockerfile change — it's a one-liner.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 27, 2026

MCP-441

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, intentional change with no correctness or security issues.

The builder stage is ephemeral — only the jlink-optimized JDK output is copied into the final alpine:3.23.4 image. Switching to the floating eclipse-temurin:21-jdk-alpine tag means builds will pick up the latest Java 21 patch automatically, which is consistent with how the Gradle toolchain is configured (JavaLanguageVersion.of(21), major-version only). The shipped runtime image is unaffected.

🗣️ Give feedback

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit ec30711 into master Apr 27, 2026
12 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the use_generic_java_version branch April 27, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants