Skip to content

MCP-436 Move away from a deprecated constructor.#358

Merged
Krosovok merged 1 commit intomasterfrom
task/vt/adjust-to-new-slcore
Apr 24, 2026
Merged

MCP-436 Move away from a deprecated constructor.#358
Krosovok merged 1 commit intomasterfrom
task/vt/adjust-to-new-slcore

Conversation

@Krosovok
Copy link
Copy Markdown
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Move away from a deprecated constructor. MCP-436 Move away from a deprecated constructor. Apr 24, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 24, 2026

MCP-436

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 24, 2026

Summary

This PR updates a single constructor call in BackendService to match an API change in SonarLint Core (SLCORE). The LanguageSpecificRequirements constructor's second parameter has changed from null to false, indicating the API now expects a boolean instead of a nullable type. This is a minimal, focused change addressing deprecation warnings from the updated dependency.

What reviewers should know

What to check:

  • Verify the second parameter value (false) is semantically correct for this use case. The parameter likely controls a boolean feature flag or requirement.
  • Check if there are other instances of new LanguageSpecificRequirements() elsewhere in the codebase that should also be updated.

Context:

  • Single-line change in BackendService.java:273
  • Part of a broader effort to adjust to new SLCORE APIs (see branch name)
  • No logic changes, just API surface update

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@Krosovok Krosovok merged commit c0f4822 into master Apr 24, 2026
14 checks passed
@Krosovok Krosovok deleted the task/vt/adjust-to-new-slcore branch April 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants