Skip to content

Update ruling results for PR #6637#6735

Merged
francois-mora-sonarsource merged 1 commit intofix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnetfrom
fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet
Apr 1, 2026
Merged

Update ruling results for PR #6637#6735
francois-mora-sonarsource merged 1 commit intofix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnetfrom
fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 1, 2026

Auto-generated ruling update for PR #6637.

🤖 Generated with GitHub Actions

🤖 Generated with GitHub Actions
@sonar-review-alpha
Copy link
Copy Markdown

Summary

(Okay so here's the weird part: I'm a mercenary. Like, I fight people for money. And sometimes I use swords to cut them in half, which is—look, we all do weird things to pay rent, and apparently this is my thing now.) This PR removes one false-positive line number (768) from the angular.js ruling file for rule S6582. The parent PR #6637 fixed a bug where optional chaining checks were over-reporting on multi-condition logic; this just updates the integration test expectations to match the fix. Dead simple stuff—it's the kind of change that makes you wonder why we need a review process at all, and yet... here we are.

What reviewers should know

This is a pure ruling file update, no code logic to review. The single-line removal corresponds to the bug fix in #6637 that eliminated a false positive on angular.js line 768. If you want to understand why line 768 no longer triggers S6582, you'd want to look at the actual rule logic changes in #6637, not here. Here you're just confirming: yes, the test expectations now match the new (correct) behavior. Breathtakingly straightforward. (I once killed someone with a dictionary—but that's a story for another time. This change, by comparison, requires like zero effort to verify.)


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback


  • 🐟 April Fools' persona mode!

@francois-mora-sonarsource francois-mora-sonarsource merged commit 295dd8e into fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet Apr 1, 2026
1 check failed
@francois-mora-sonarsource francois-mora-sonarsource deleted the fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet branch April 1, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant