Skip to content

Update ruling results for PR #6555#6733

Closed
github-actions[bot] wants to merge 1 commit intofix/JS-1423-fix-fp-on-s7778-methods-accepting-only-a-single-argument-incorrectly-flagged-as-combinable-sonnetfrom
fix/update-ruling-for-fix/JS-1423-fix-fp-on-s7778-methods-accepting-only-a-single-argument-incorrectly-flagged-as-combinable-sonnet
Closed

Update ruling results for PR #6555#6733
github-actions[bot] wants to merge 1 commit intofix/JS-1423-fix-fp-on-s7778-methods-accepting-only-a-single-argument-incorrectly-flagged-as-combinable-sonnetfrom
fix/update-ruling-for-fix/JS-1423-fix-fp-on-s7778-methods-accepting-only-a-single-argument-incorrectly-flagged-as-combinable-sonnet

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 1, 2026

Auto-generated ruling update for PR #6555.

🤖 Generated with GitHub Actions

🤖 Generated with GitHub Actions
@sonar-review-alpha
Copy link
Copy Markdown

Summary

Ahh, here we have a tally of the seas adjusted, mate. Rule S7778 — the one concernin' methods that be combinable, savvy? — has been set straight in PR #6555, and now we're updatin' the expected bounty of violations across our fleet of test repositories. The rule was flaggin' innocent single-argument methods as combinable when they had no business bein' chained together. This ruling update reflects the correction: some false alarms have been scrubbed from the ledger, whilst a few genuine violations that slipped past the watch have now been properly logged. Four new projects join the roster with expected violations (http, paper.js, prettier-vscode, sonar-web), and the rest have their line numbers adjusted to match the rule's newfound clarity.

What reviewers should know

The changes be purely in the expected test results — no code changes, just the test expectations updated to align with PR #6555's fix. Start by understandin' that rule S7778 flags method chains, and the issue was overzealous flaggin' of methods that only accept a single argument (which cannot be combined in the manner the rule was warnin' about). Each JSON file represents expected violations per project: additions mean the rule now correctly catches violations it missed before, removals mean false positives have been eliminated. The Ghost project shows the most substantial adjustments — likely a codebase with many test cases. If ye need to verify the actual rule change, that be in PR #6555; this PR is merely ensurin' the test suite knows what violations to expect from the updated rule.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback


  • 🐟 April Fools' persona mode!

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

A clean and correct auto-generated update, mate — nothing aboard this vessel that ought to give a reviewer pause. The ruling snapshots reflect precisely the adjusted reach of the S7778 rule as fixed in PR #6555, and the ledger balances true.

🗣️ Give feedback

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 1, 2026

No longer needed — the original PR is now up to date.

@github-actions github-actions bot closed this Apr 1, 2026
@github-actions github-actions bot deleted the fix/update-ruling-for-fix/JS-1423-fix-fp-on-s7778-methods-accepting-only-a-single-argument-incorrectly-flagged-as-combinable-sonnet branch April 1, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants