Skip to content

Update ruling results for PR #6637#6722

Merged
francois-mora-sonarsource merged 1 commit intofix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnetfrom
fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet
Mar 31, 2026
Merged

Update ruling results for PR #6637#6722
francois-mora-sonarsource merged 1 commit intofix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnetfrom
fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Auto-generated ruling update for PR #6637.

🤖 Generated with GitHub Actions

🤖 Generated with GitHub Actions
@sonar-review-alpha
Copy link
Copy Markdown

Summary

This PR removes the expected test results file for rule S7727 on the it-tools test project. The deletion indicates that the fix from PR #6637 (addressing false positives in rule S6582 with optional chaining and multi-condition logic) has resolved issues that were previously triggering S7727 at lines 19 and 117 in the useQRCode.ts files.

What reviewers should know

This is a straightforward ruling update: verify that the deleted expected results file (typescript-S7727.json) reflects the intended outcome of PR #6637. The it-tools test project should no longer report violations of rule S7727 at those specific lines. If this deletion seems unexpected or S7727 violations reappear in actual testing, check whether PR #6637's fix inadvertently affected S7727's detection logic.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Minimal, auto-generated ruling update — the single deleted file correctly reflects the removal of false-positive S7727 findings that resulted from the fix in PR #6637. Nothing to flag here.

🗣️ Give feedback

@francois-mora-sonarsource francois-mora-sonarsource merged commit 5cb1349 into fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet Mar 31, 2026
2 checks passed
@francois-mora-sonarsource francois-mora-sonarsource deleted the fix/update-ruling-for-fix/JS-1462-fix-fp-on-s6582-multi-condition-logic-with--and--cannot-use-optional-chaining-sonnet branch March 31, 2026 10:24
francois-mora-sonarsource pushed a commit that referenced this pull request Apr 1, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant