Replace Pin markers with configurable 3D MeasurementMarker in tape tool#447
Replace Pin markers with configurable 3D MeasurementMarker in tape tool#447ndejardin425 wants to merge 1 commit intoSmithsonian:masterfrom
Conversation
25c108b to
ab77524
Compare
|
@gjcope did you had time to look it is ? To give you the full picture, even if it's virtual, some of our users were not keen on placing pins on old objects. It's purely psychological, but I can understand it. |
|
Hey @ndejardin425 , apologies for the delay. I had a look and the only thing that concerns me is that it adds a decent amount of code to the frontend Explorer package that will likely not get used on our end. We haven't gotten any similar feedback from our curators, but I can see the argument. When time allows I'd like to demo the options you put together and maybe pick an alternate to include based on consensus. There's also something to be said for consistency across experiences. Do foresee needing all of these options for your use cases? |
No, we won't need all the options, just a "non-invasive" alternative to the pin marker |
|
@ndejardin425 Is there a reason this choice is Explorer-side? It seems like it would be a Story-side configuration option that is serialized in the scene file. If you have a good use case for this though, I am open. |
|
for me, it should depend more on the configuration of the explorer than an option in the scene. |
So you anticipate end users needing to change the pin style? I'm not sure our users would make use of that. I would think that organizationally if you are opposed to pins, you would change the style used for your scenes. I'm not sure I see the value of the added front-end UI. Are you getting requests for end user configurability (outside of just having a marker other than a pin)? |
I think it would better to change the style used in Voyager components configuration than in every scene we will create or use. So the measure marker would be another one than a pin for all our users, no configuration based on each user. |
|
It seems like what you are looking for then is the ability to configure a different pin default for the viewer. I don't think we need pin options on the end user side unless there is a compelling motivation or use case for it. Would an API attribute work for you? |
Yep, it will work for us. |
Summary
MeasurementMarkerclass hierarchy with 5 marker styles: Sphere, Ring, Crosshair, Disc, and PinChanges
MeasurementMarker.ts: Implements abstract base class and 5 marker styles designed for museum contexts where pin-style markers suggesting surface penetration are inappropriateCVTape.ts: ReplacedPinwithMeasurementMarker, addedmarkerStyleproperty with dynamic style switching supportsetup.tsschema: AddedTMarkerStyletype and optionalmarkerStyleproperty toITapeinterfacePin.ts: Functionality moved toPinMarkerclass within the new marker systemMarker Styles
Test Plan