fix croesus overlay

[davishi25]

regex for croesus chests was renamed a while ago, this fix should update the regex to fit the current chest and item names

[gemini-code-assist]

Summary of Changes

Hello @davishi25, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues with the Croesus overlay by updating various string matching patterns and item identification logic. The changes ensure that the overlay correctly recognizes and processes Croesus chests, their contents, and associated status messages, adapting to recent modifications in the game's text and naming conventions.

Highlights

• Croesus Chest Regex Update: The regular expression used to identify Croesus chests (croesusChestRegex) has been updated to accurately match current in-game naming conventions, specifically removing 'Mode ' from 'Master Mode' and 'The ' from 'The Catacombs'.
• Chest Type Retrieval Adjustment: The logic for retrieving the DungeonChest type now appends ' Chest' to the item's display name before calling DungeonChest.getFromName, ensuring correct identification based on updated item names.
• Lore Message String Correction: The string matching for in-game lore messages related to chest status has been updated to reflect new wording and casing, specifically for 'No more chests to open!' and 'No chests opened yet!'.
• Enchanted Book Name Color Fix: The color code used for 'Enchanted Book' names has been changed from green (§a) to white (§f) to match the current in-game display.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates various regular expressions and string literals to align with recent changes to in-game text, specifically for the Croesus overlay. The modifications seem correct and address the intended issue of adapting to new chest and item names. I have one suggestion to improve the robustness of the updated regular expression for chest names.

[gemini-code-assist]

The regex (IV|V?I{0,3}) for Roman numerals is a bit too broad, as I{0,3} can match an empty string. This could cause a string like "Catacombs - Floor " (with a trailing space) to match the regex, which is likely not intended. A more precise regex would prevent matching an empty floor number.

Suggested change

	private val croesusChestRegex = Regex("^(Master )?Catacombs - Flo(or (IV|V?I{0,3}))?$")
	private val croesusChestRegex = Regex("^(Master )?Catacombs - Flo(or (IV|V?I{1,3}))?$")