Skip to content

Conversation

@IrinaWei
Copy link
Contributor

@IrinaWei IrinaWei commented Feb 4, 2026

This pr is raised to resolve the gap between changelog and the actual release content, see the context here:
The published npm package (41.9.0) was built from commit d6af21f (Phase 2: Basic Atomic Components PR #4179)
• But the git tag 41.9.0 points to an earlier commit (6bc2bcd)
• This means the data-backpack-ds-component attributes added to BpkText (and other components) are in the npm package but not reflected in the tag/changelog
this is because when tag is created there might be new pr merge in main, and the publish process would refer to the latest main code, in this pr, now the publish process would refer to the commit when tag is created and the prs merged into main afterwards would stay in draft

And for the reason why only the ref for release process has changed: Only the ReleaseWeb job actually builds and publishes the npm package, so modifying just that job ensures the published code matches the tag; modifying the other jobs is purely a performance optimization to avoid cache misses, not a functional requirement.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copilot AI review requested due to automatic review settings February 4, 2026 07:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IrinaWei IrinaWei added the patch Patch production bug label Feb 4, 2026
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4211 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch production bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants