WXYZ property and handler reorganization#8274
Merged
sovdeeth merged 7 commits intoSkriptLang:dev/featurefrom Dec 27, 2025
Merged
WXYZ property and handler reorganization#8274sovdeeth merged 7 commits intoSkriptLang:dev/featurefrom
sovdeeth merged 7 commits intoSkriptLang:dev/featurefrom
Conversation
Efnilite
requested changes
Nov 5, 2025
Member
Efnilite
left a comment
There was a problem hiding this comment.
will take a closer look later, looks good on first glance
src/main/java/org/skriptlang/skript/bukkit/base/types/LocationClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/Property.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/ContainsHandler.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/base/ConditionPropertyHandler.java
Show resolved
Hide resolved
Absolutionism
previously requested changes
Nov 5, 2025
src/main/java/org/skriptlang/skript/lang/properties/handlers/ContainsHandler.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/TypedValueHandler.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/WXYZHandler.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/base/ConditionPropertyHandler.java
Show resolved
Hide resolved
...main/java/org/skriptlang/skript/lang/properties/handlers/base/ExpressionPropertyHandler.java
Show resolved
Hide resolved
Member
Author
I don't want to do that until we're sure properties is ready for full release, so it'll be a different pr |
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
…XYZHandler.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Efnilite
approved these changes
Dec 2, 2025
APickledWalrus
approved these changes
Dec 23, 2025
src/main/java/org/skriptlang/skript/lang/properties/handlers/TypedValueHandler.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/properties/handlers/WXYZHandler.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Many things have coordinates. Vanilla Skript includes 3 currently, Location, Vector, and Quaternion, though Chunk should also be included. Unifying these under a single property removes the confusion of
x componentvsx coordinateand allows many more types to use thex ofsyntax.Solution
Adds a property for WXYZ components, where the handler is able to declare which axes it supports.
I've also tried to sneak in 40 other files worth of reorganization changes, moving Handlers out to their own classes to avoid another massive DefaultX-like class. These have no functional impact, and can mostly be ignored when reviewing.
I decided on a combined WXYZ property for boilerplate's sake. I had a separate property for each axis, which does lower complexity for each individual handler, but leads to a lot of duplicated code between each one for each class. Since most things in Skript will deal with at least 2 axis and normally 3 or more, I thought it simpler for the user to just combine the property into one. If anyone has good arguments against this, I'm all ears.
Testing Completed
All prior behavior is maintained via existing tests. Manual testing confirms interactions with things like player velocity.
Supporting Information
Breaking changes: removes
[vector|quaternion]from the component syntax (vector x of {var})Completes: none
Related: none