Draft
Conversation
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
Member
|
Haven't looked at code, but I would like the property to be called ORDERED_ELEMENTS as some things could have elements without ordered access. Actually maybe order implies sorting, idk. Something that makes it clear you can access elements by index. |
…Elements # Conflicts: # src/main/java/org/skriptlang/skript/common/properties/expressions/PropExprValueOf.java # src/main/java/org/skriptlang/skript/common/types/QueueClassInfo.java # src/main/java/org/skriptlang/skript/lang/properties/Property.java # src/main/java/org/skriptlang/skript/lang/properties/PropertyBaseSyntax.java # src/main/java/org/skriptlang/skript/lang/properties/PropertyHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no way for addons to be able to use container objects, such as SkriptQueue, and to to be used in ExprElements.
Solution
Adds a property handler, ElementHandler, allowing to get elements from an object, with either a specific index or a range.
Adds a property, ELEMENTS, that is used on SkriptQueue
Adds a property handler, ReturnablePropertyHandler that pulls out 'returnType' and 'possibleReturnTypes' from 'ExpressionPropertyHandler'
'ExpressionPropertyHandler' and 'ElementHandler' extend 'ReturnablePropertyHandler'
Pulls out 'getPropertyReturnTypes' from 'PropertyBaseExpression' to 'PropertyBaseSyntax',
Adds an additional 'getPropertyReturnTypes' for a handler extending 'ReturnablePropertyHandler'
Adds PropExprElements that is a property version of ExprElements.
Testing Completed
quickTest
Supporting Information
N/A
Note
PR currently fails due to pattern conflicts from property syntax elements.
This PR will stay in draft until properties are officially released in 2.14
Completes: none
Related: none