fix(markdown_viewer): wrap long lines in table cells to fit terminal width#63
Open
sideshowbarker wants to merge 1 commit intoSkardyy:mainfrom
Open
fix(markdown_viewer): wrap long lines in table cells to fit terminal width#63sideshowbarker wants to merge 1 commit intoSkardyy:mainfrom
sideshowbarker wants to merge 1 commit intoSkardyy:mainfrom
Conversation
…width Problem: When a table cell contains a line longer than the terminal width, the line unexpectedly doesn’t get wrapped within the cell. Cause: Column widths were just computed as the max content width of any cell in the column — with no regard for the terminal width. Fix: After computing column widths, cap them to fit within the terminal using a “waterfall” algorithm that keeps narrow columns at their natural size and only shrinks wider columns. Lines that exceeds the capped width are wrapped using a new ANSI-aware wrap_cell_text function that preserves formatting across wrapped lines.
sideshowbarker
force-pushed
the
feat/table-cell-wrapping
branch
from
5bdadc5 to
5c08de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a table cell contains a line longer than the terminal width, the line unexpectedly doesn't get wrapped within the cell.
Cause: Column widths were just computed as the max content width of any cell in the column — with no regard for the terminal width.
Fix: After computing column widths, cap them to fit within the terminal using a "waterfall" algorithm that keeps narrow columns at their natural size and only shrinks wider columns. Lines that exceed the capped width are wrapped using a new ANSI-aware
wrap_cell_textfunction that preserves formatting across wrapped lines.