This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Replace multispinner with listr in build.js#971
Merged
XanderLuciano merged 1 commit intoSimulatedGREG:masterfrom Apr 21, 2021
Merged
Replace multispinner with listr in build.js#971XanderLuciano merged 1 commit intoSimulatedGREG:masterfrom
XanderLuciano merged 1 commit intoSimulatedGREG:masterfrom
Conversation
shuai132
reviewed
May 12, 2021
| console.error(`\n${err}\n`) | ||
| process.exit(1) | ||
| }) | ||
| const tasks = new Listr( |
There was a problem hiding this comment.
already has var named tasks
const tasks = ['main', 'renderer']
There was a problem hiding this comment.
Yes why a such mistake, alll the build pipeline is broken now.
How could this have been merged into master?
If we try to fix it and change its name, we get another error, like Multispinner is not declared.
Is there a fix for that?
Edit: Ok i proposed a fix right here #1090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #924
multispinneris not maintained, and it has security issues. So I propose replacingmultispinnerwith another one.In this pull request, I am using
listr.listrcan execute multiple tasks in parallel, so I think that it is enough to meet this requirement.I have already used this script in my project, it looks like here:
