Skip to content

fix: R19 admin UI corrections#2405

Merged
tkurki merged 1 commit intoSignalK:masterfrom
dirkwa:fix-r19-admin-ui-corrections
Mar 5, 2026
Merged

fix: R19 admin UI corrections#2405
tkurki merged 1 commit intoSignalK:masterfrom
dirkwa:fix-r19-admin-ui-corrections

Conversation

@dirkwa
Copy link
Contributor

@dirkwa dirkwa commented Mar 3, 2026

Several small fixes for the React 19 admin UI:

  • Fix permissions dropdown: Replace deprecated Form.Control type="select" with Form.Select (React Bootstrap 5) in Access Requests and Devices views — the dropdown was rendering as a text input instead of a select
  • Default token expiration to NEVER: Match the server-side default in both R19 and R16 admin UIs (was 1y)
  • Force discovered providers to enabled: When clicking a discovered provider in Connections, set enabled: true so it's ready to use
  • Re-run discovery after delete: After deleting a connection, re-run mDNS discovery so the provider reappears in the discovered list without a page reload

Testing done

  • Sent a device access request, verified the permissions dropdown renders as a proper <select> element
  • Verified expiration field defaults to NEVER

Fix Form.Control type=select to Form.Select (React Bootstrap 5) in
AccessRequests and Devices views. Default token expiration to NEVER
in both admin UIs to match the server-side default. Force discovered
providers to enabled when selected, and re-run discovery after
deleting a connection so it reappears without a page reload.
@tkurki tkurki added the fix label Mar 5, 2026
@tkurki tkurki merged commit 15d7ddd into SignalK:master Mar 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants