fix: reconnect WebSocket after login/logout in R19 admin UI#2403
Merged
tkurki merged 1 commit intoSignalK:masterfrom Mar 3, 2026
Merged
fix: reconnect WebSocket after login/logout in R19 admin UI#2403tkurki merged 1 commit intoSignalK:masterfrom
tkurki merged 1 commit intoSignalK:masterfrom
Conversation
Reconnect the admin UI WebSocket connection after login and logout so the server associates the correct authentication state with event subscriptions like ACCESS_REQUEST and DISCOVERY_CHANGED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After login or logout, the R19 admin UI did not reconnect its WebSocket. This meant the server kept the old authentication state for the connection — an admin who logged in wouldn't receive admin-only events like
ACCESS_REQUEST, and logging out wouldn't drop those subscriptions until page refresh.Now the WebSocket is explicitly reconnected after login and logout so the server associates the correct authentication state with event subscriptions.
Also adds handling for the
RECEIVE_LOGIN_STATUSserver event so login state updates are pushed to the UI in real time.Testing done
VESSEL_INFO,PROVIDERSTATUS,SERVERSTATISTICS,RECEIVE_LOGIN_STATUS, etc.)