feat: track and display device token expiry in admin UI#2369
Open
dirkwa wants to merge 4 commits intoSignalK:masterfrom
Open
feat: track and display device token expiry in admin UI#2369dirkwa wants to merge 4 commits intoSignalK:masterfrom
dirkwa wants to merge 4 commits intoSignalK:masterfrom
Conversation
Store the JWT exp claim as tokenExpiry when approving device access requests, making it available via the devices API for admin UI display.
Add Token Expiry column to the devices table and detail view showing remaining time or an Expired badge. Fetch devices via the store so the sidebar can also access device data.
Show a red badge on the Security menu item for expired device tokens and a green badge for pending access requests. Hide parent badges when the dropdown is expanded since children show their own.
Replace Form.Control type="select" with Form.Select to avoid React 19 error SignalK#137 (void element with children). Default expiration to 1y.
sbender9
approved these changes
Mar 3, 2026
tkurki
reviewed
Mar 3, 2026
Member
tkurki
left a comment
There was a problem hiding this comment.
@sbender9 how does this look to you?
I often dislike human oriented time expressions and yearn for the exact time when something has happened / will happen. How about showing that on hover? Tiny detail, I know...
Another point would be to have "last seen" timestamp for tokens. Expiry is one thing, but last seen is often more valuable. Trouble is that would need persistence, and I don't want to complicate things with something like that right now, as I think we should start using node:sqlite and skserver.sqlite for stuff like this. So maybe file that for later, or another PR...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expclaim astokenExpiryon device records when approving access requestsForm.Control type="select"→Form.Selectin AccessRequests to resolve React 19 error Handle error in certificate creation #137Tested
60s) and verifytokenExpiryappears in the Devices tableImages