Conversation
H4ad
previously approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Not blocking: Maybe adding a test for to ensure this will not be erased/ignored in the future? You will need to mock the window.getSelection
reply --
Added a unit test for useLogDetailHandlers to guard the text-selection check in handleSetActiveLog
H4ad
approved these changes
Feb 23, 2026
Member
|
@cursor review |
aks07
approved these changes
Feb 25, 2026
ishan621
added a commit
that referenced
this pull request
Feb 25, 2026
* feat: text selection block * chore: added test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR handles a bug, in logs explorer when we used to select a text , it would automatically open log detail which was a bad UX as user was just trying to select and copy a value.
Fix - We have introduced a hook , which tells us if text is selected , if yes then we don't open log detail else it will behave as normal.
📄 Summary
Screenshots / Screen Recordings (if applicable)
Before :
Screen.Recording.2026-02-20.at.6.29.48.PM.mov
After :
Screen.Recording.2026-02-20.at.6.30.58.PM.mov
Issues closed by this PR
#3903
✅ Change Type
Select all that apply
🐛 Bug Context
Required if this PR fixes a bug
Root Cause
What caused the issue?
Faulty assumption
Fix Strategy
Root cause: we were not distinguishing between text selection and click events, which led to the issue. Many libraries handle this behavior inherently, but react-virtuoso does not provide it out of the box, so we needed to implement the handling manually.
🧪 Testing Strategy
How was this change validated?
Tests added/updated: Yes
Manual verification: Yes
Edge cases covered: Yes
📋 Checklist
Tests added