Update liquid-spec adapters for missing_features#2079
Merged
Conversation
Maaarcocr
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our liquid-spec adapters for Shopify/liquid-spec#134, which inverted feature gating from adapter allowlists to explicit
missing_featuresdenylists.A few follow-up fixes were needed once the suite started running more specs:
rake specnow runs each adapter independently instead of matrix-comparing strict/lax adapters.ruby-versionnow matches the repo's Ruby 4.0.2 environmentVerified with:
shadowenv exec -- bundle exec rake specshadowenv exec -- bundle exec rubocop Rakefile spec/ruby_liquid.rb spec/ruby_liquid_lax.rb spec/ruby_liquid_with_active_support.rb spec/ruby_liquid_yjit.rb spec/support/liquid_spec_adapter_helper.rb