fix: add missing valid enum values to ground truth in live_simple and live_parallel#1329
Open
octo-patch wants to merge 1 commit intoShishirPatil:mainfrom
Open
Conversation
… live_parallel (fixes ShishirPatil#1314) For cmd_controller.execute entries (live_simple_141, 143, 156, 159): - unit enum has ["seconds", "milliseconds"] but ground truth only accepted ""/"N/A" - Added "seconds" and "milliseconds" as valid accepted values For get_current_weather/get_snow_report entries (live_parallel_3, 6, 13): - unit enum has ["celsius", "fahrenheit"] but ground truth only accepted ""/"fahrenheit" - Added "celsius" as a valid accepted value since it is in the enum Co-Authored-By: Octopus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1314
Problem
9 ground truth entries in
live_simpleandlive_parallelcategories reject valid model outputs that are allowed by the function schema:cmd_controller.execute—unitparam (4 entries in live_simple)Entries:
live_simple_141-94-0,live_simple_143-95-0,live_simple_156-95-13,live_simple_159-95-16The
unitparameter hasenum: ["seconds", "milliseconds"]anddefault: "N/A". The ground truth only accepted""or"N/A", rejecting"seconds"and"milliseconds"which are the valid enum values defined in the schema.get_current_weather/get_snow_report—unitparam (3 entries in live_parallel)Entries:
live_parallel_3-0-3,live_parallel_6-3-0,live_parallel_13-9-0The
unitparameter hasenum: ["celsius", "fahrenheit"]anddefault: "fahrenheit". The ground truth only accepted""or"fahrenheit", rejecting"celsius"— a valid enum value. Two of the three entries query locations in Celsius-speaking regions (Mexico in Spanish, France), making"celsius"a particularly reasonable choice.Solution
cmd_controller.executeentries: added"seconds"and"milliseconds"to accepted values in ground truth"celsius"to accepted values in ground truthThis is strictly additive — previously accepted values are unchanged, only missing valid enum values are added.
Testing
Verified the updated ground truth entries by re-reading the modified JSONL files and confirming all changes match the issue description.