Add run_fixedTarget summary#1140
Conversation
olantwin
left a comment
There was a problem hiding this comment.
We should be able to automatically parse the command line and add command name as well as all arguments, or get these from argparse.
I'll take care of the commit messages when squashing. Could you add a change log entry?
|
Forgot to add: This is a very nice addition, we should probably try to add this also to run_simScript.py (and include this as a feature for the new framework from the get-go). |
|
Yes - I think for run_simScript.py and also the digi and reconstruction we need to make a bit more of a framework to update the existing dictionary (i.e. these were the files going in, as well as what this script did) which will require some thought |
Maybe we can make helper to register metadata and another to write all metadata at the end of sim/reco run? |
|
Yes, I think ultimately that will be the aim. For now, shall we proceed with this for the the productions? |
Yes, I'd proceed with this as is for now. |
|
This looks good to me. |
THanae
left a comment
There was a problem hiding this comment.
Looks good to me as well.
Probably missing a few things, but you get the idea
Checklist