Skip to content

Add run_fixedTarget summary#1140

Merged
olantwin merged 12 commits intoShipSoft:masterfrom
mesmith75:add_file_summary
Apr 9, 2026
Merged

Add run_fixedTarget summary#1140
olantwin merged 12 commits intoShipSoft:masterfrom
mesmith75:add_file_summary

Conversation

@mesmith75
Copy link
Copy Markdown
Contributor

@mesmith75 mesmith75 commented Apr 2, 2026

Probably missing a few things, but you get the idea

Checklist

@mesmith75 mesmith75 requested a review from a team as a code owner April 2, 2026 15:17
@mesmith75 mesmith75 requested a review from olantwin April 2, 2026 15:17
@olantwin olantwin requested a review from THanae April 2, 2026 16:55
Copy link
Copy Markdown
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to automatically parse the command line and add command name as well as all arguments, or get these from argparse.

I'll take care of the commit messages when squashing. Could you add a change log entry?

@olantwin
Copy link
Copy Markdown
Contributor

olantwin commented Apr 7, 2026

Forgot to add: This is a very nice addition, we should probably try to add this also to run_simScript.py (and include this as a feature for the new framework from the get-go).

@mesmith75
Copy link
Copy Markdown
Contributor Author

mesmith75 commented Apr 7, 2026

Yes - I think for run_simScript.py and also the digi and reconstruction we need to make a bit more of a framework to update the existing dictionary (i.e. these were the files going in, as well as what this script did) which will require some thought

@olantwin
Copy link
Copy Markdown
Contributor

olantwin commented Apr 7, 2026

Yes - I think for run_simScript.py and also the digi and reconstruction we need to make a bit more of a framework to update the existing dictionary (i.e. these were the files going in, as well as what this script did) which will require some thought

Maybe we can make helper to register metadata and another to write all metadata at the end of sim/reco run?

@mesmith75
Copy link
Copy Markdown
Contributor Author

mesmith75 commented Apr 7, 2026

Yes, I think ultimately that will be the aim. For now, shall we proceed with this for the the productions?

@olantwin
Copy link
Copy Markdown
Contributor

olantwin commented Apr 7, 2026

Yes, I think ultimately that will be the aim. For now, shall we proceed with this for the sake of the productions?

Yes, I'd proceed with this as is for now.

@olantwin
Copy link
Copy Markdown
Contributor

olantwin commented Apr 9, 2026

This looks good to me.
As soon as @THanae is satisfied with what is saved, we can merge this (or merge and update after in a new PR?)

Copy link
Copy Markdown
Contributor

@THanae THanae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@olantwin olantwin merged commit ab703c8 into ShipSoft:master Apr 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants