Open
Conversation
olantwin
requested review from
a team,
Gfrisella,
eduard322,
jasminwss,
matclim and
wcmartylee
as code owners
olantwin
force-pushed
the
fix/ci-build-warnings
branch
from
387ab90 to
641e046
Compare
wcmartylee
previously approved these changes
Mar 24, 2026
Gfrisella
previously approved these changes
Mar 24, 2026
olantwin
force-pushed
the
fix/ci-build-warnings
branch
from
641e046 to
b7654f8
Compare
Contributor
Author
|
@kholoimov @jasminwss @eduard322 @matclim Could you please review this as code owners of some of the affected code? |
jasminwss
previously approved these changes
Apr 7, 2026
jasminwss
left a comment
jasminwss
left a comment
There was a problem hiding this comment.
I was not able to meaningfully review the remaining 2 files (LinkDef.h and Generator.h) as I am relatively new to this codebase, but nothing I reviewed raised any concerns
Contributor
Author
Thanks @jasminwss ! |
3 tasks
|
I think it will be important to squash the commits before merging, as the first commit is breaking The rest is fine for me |
kholoimov
previously approved these changes
Apr 8, 2026
matclim
previously approved these changes
Apr 8, 2026
olantwin
force-pushed
the
fix/ci-build-warnings
branch
from
b7654f8 to
8258d7f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (36)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (16)
🚧 Files skipped from review as they are similar to previous changes (16)
📝 WalkthroughWalkthroughThis pull request updates C++11 virtual method declarations across 50+ header files to use explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
passive/ShipMuonShield.h (1)
28-28:⚠️ Potential issue | 🟡 MinorMissing
overridespecifier onConstructGeometry().
ShipMuonShield::ConstructGeometry()overrides a virtual method fromFairModulebut lacks theoverridespecifier, inconsistent with the same method inShipCave.h(line 17).Proposed fix
- void ConstructGeometry(); + void ConstructGeometry() override;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@passive/ShipMuonShield.h` at line 28, The method declaration for ShipMuonShield::ConstructGeometry() is missing the override specifier; update the declaration in ShipMuonShield.h to mark ConstructGeometry() as overriding the virtual method from FairModule (i.e., add the override keyword to the method signature) so it matches the style used in ShipCave.h and ensures compiler-checked overriding.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@splitcal/splitcalCluster.h`:
- Line 83: The macro used for ROOT dictionary generation is incorrect: replace
ClassDefOverride with ClassDef for the class splitcalCluster because it inherits
directly from TObject (which is not a ClassDef-instrumented subclass); locate
the declaration containing ClassDefOverride(splitcalCluster, 4) and change it to
ClassDef(splitcalCluster, 4) so the ROOT instrumentation matches the inheritance
(do not alter base class TObject or other macros).
---
Outside diff comments:
In `@passive/ShipMuonShield.h`:
- Line 28: The method declaration for ShipMuonShield::ConstructGeometry() is
missing the override specifier; update the declaration in ShipMuonShield.h to
mark ConstructGeometry() as overriding the virtual method from FairModule (i.e.,
add the override keyword to the method signature) so it matches the style used
in ShipCave.h and ensures compiler-checked overriding.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42b6540d-38b4-4d54-bb86-1ba92a75fba8
📒 Files selected for processing (37)
CHANGELOG.mdDetector/DetectorPoint.hSND/EmulsionTarget/TTPoint.hSND/EmulsionTarget/TargetPoint.hSND/MTC/MTCDetHit.hSND/MTC/MTCDetPoint.hSND/SiliconTarget/SiliconTargetHit.hSND/SiliconTarget/SiliconTargetPoint.hTimeDet/TimeDetHit.hUpstreamTagger/UpstreamTaggerHit.hfield/LinkDef.hfield/ShipBFieldMap.hfield/ShipBellField.cxxfield/ShipBellField.hfield/ShipCompField.hfield/ShipConstField.cxxfield/ShipConstField.hfield/ShipFieldCreator.hfield/ShipFieldPar.hpassive/ShipCave.hpassive/ShipGeoCave.hpassive/ShipMagnet.hpassive/ShipMuonShield.hpassive/ShipPassiveContFact.hpassive/ShipTAUMagneticSpectrometer.hpassive/ShipTargetStation.hshipdata/ShipMCTrack.hshipdata/ShipStack.hshipgen/Generator.hsplitcal/splitcalCluster.hsplitcal/splitcalContFact.hsplitcal/splitcalHit.hstrawtubes/strawtubesContFact.hstrawtubes/strawtubesHit.hveto/vetoContFact.hveto/vetoHit.hveto/vetoHitOnTrack.h
💤 Files with no reviewable changes (1)
- field/LinkDef.h
olantwin
force-pushed
the
fix/ci-build-warnings
branch
from
8258d7f to
1c6ffca
Compare
Use override instead of virtual, ClassDefOverride instead of ClassDef where appropriate, nullptr instead of 0, = default for trivial constructors, and add missing includes.
olantwin
force-pushed
the
fix/ci-build-warnings
branch
from
1c6ffca to
259c6b1
Compare
olantwin
requested review from
Gfrisella,
jasminwss,
kholoimov,
matclim and
wcmartylee
Contributor
Author
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
1 similar comment
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
Contributor
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
wcmartylee
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ClassDefOverride instead of ClassDef for classes inheriting from TObject, fix Print() and Init() virtual hiding in field and generator classes, and remove unused FairShipFields LinkDef entry.
Checklist
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores