[Doc] fix some stuff in quickstart & set ACPP_DEBUG_LEVEL=0 in envs#1770
[Doc] fix some stuff in quickstart & set ACPP_DEBUG_LEVEL=0 in envs#1770tdavidcl merged 3 commits intoShamrock-code:mainfrom
Conversation
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and environment setup scripts for AdaptiveCPP. Key changes include adding the fmt dependency to the MacOS installation guide, standardizing argument order in the new-env script, and explicitly setting ACPP_DEBUG_LEVEL=0 across several environment configurations. Review feedback highlights an inconsistency in the MacOS quickstart guide where the OpenMP backend flag was inadvertently removed and suggests using brew --prefix for a more efficient and robust method of locating the AdaptiveCPP installation path on MacOS.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the quickstart documentation to include the fmt dependency, reorders command-line arguments for clarity, and adds notes regarding benchmark variability and MacOS virtualenv warnings. Environment scripts across multiple platforms were updated to set ACPP_DEBUG_LEVEL=0, fix shell redirection spacing, and modernize command substitution in the MacOS script. No review comments were provided, and I have no feedback to provide.
Workflow reportworkflow report corresponding to commit a467901 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
No description provided.