Skip to content

[Doc] fix some stuff in quickstart & set ACPP_DEBUG_LEVEL=0 in envs#1770

Merged
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:patch-2026-04-22-12-28
Apr 22, 2026
Merged

[Doc] fix some stuff in quickstart & set ACPP_DEBUG_LEVEL=0 in envs#1770
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:patch-2026-04-22-12-28

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and environment setup scripts for AdaptiveCPP. Key changes include adding the fmt dependency to the MacOS installation guide, standardizing argument order in the new-env script, and explicitly setting ACPP_DEBUG_LEVEL=0 across several environment configurations. Review feedback highlights an inconsistency in the MacOS quickstart guide where the OpenMP backend flag was inadvertently removed and suggests using brew --prefix for a more efficient and robust method of locating the AdaptiveCPP installation path on MacOS.

Comment thread doc/sphinx/source/user_guide/quickstart.md
Comment thread env/machine/macos-generic/acpp/env_built_acpp.sh
@tdavidcl
Copy link
Copy Markdown
Member Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the quickstart documentation to include the fmt dependency, reorders command-line arguments for clarity, and adds notes regarding benchmark variability and MacOS virtualenv warnings. Environment scripts across multiple platforms were updated to set ACPP_DEBUG_LEVEL=0, fix shell redirection spacing, and modernize command substitution in the MacOS script. No review comments were provided, and I have no feedback to provide.

@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit a467901
Commiter email is [email protected]
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 8459 → 8459 (0.0%)

Detailed changes :

@tdavidcl tdavidcl merged commit 26a943c into Shamrock-code:main Apr 22, 2026
76 checks passed
@tdavidcl tdavidcl deleted the patch-2026-04-22-12-28 branch April 22, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant