[Base] using std::string_view rather than std::string in print#1748
[Base] using std::string_view rather than std::string in print#1748tdavidcl merged 4 commits intoShamrock-code:mainfrom
Conversation
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
There was a problem hiding this comment.
Code Review
This pull request updates the printing utility functions to use std::string_view instead of std::string, which helps reduce unnecessary string allocations and improves performance. These changes are applied to the print, println, and change_printer functions across the core library and its Python bindings. The review feedback suggests marking the internal function pointers in src/shambase/src/print.cpp as static to ensure internal linkage and prevent potential symbol collisions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Workflow reportworkflow report corresponding to commit 012397d Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
No description provided.