Bugfix: Allow dirty open handles to deleted files to be closed #791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code analysis, I think this sequence:
Would have failed to close the handle in step 4.
The impact on the user application would be a handle leak and maybe other unexpected behavior caused by close failing.
This fix checks if the file was deleted inside
flushFileInternal, and skips the upload without returning any errors, allowing close to finish and succeed.Checklist