Skip to content

Fix: it's not correct when url is new type of eclipse #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankclr wants to merge 1 commit into from
+4 −2
Closed

Fix: it's not correct when url is new type of eclipse #6445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/download.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,15 +680,17 @@ function ftp_file_size($url) {
}

function url_filename($url) {
(Split-Path $url -Leaf).split('?') | Select-Object -First 1
# eclipse-mat mirror auto selected parameter "&r=1"
# regularly, "&" should be a part of URL
(Split-Path $url -Leaf).split('?').Split('&') | Select-Object -First 1
}

function url_remote_filename($url) {
# Unlike url_filename which can be tricked by appending a
# URL fragment (e.g. #/dl.7z, useful for coercing a local filename),
# this function extracts the original filename from the URL.
$uri = (New-Object URI $url)
$basename = Split-Path $uri.PathAndQuery -Leaf
$basename = url_filename $url
If ($basename -match '.*[?=]+([\w._-]+)') {
$basename = $matches[1]
}
Expand Down