Skip to content

eclipse-mat: Update to version 1.16.1.20250109, fix checkver & autoupdate#15977

Merged
z-Fng merged 3 commits intoScoopInstaller:masterfrom
frankclr:update-eclipse-mat
Oct 19, 2025
Merged

eclipse-mat: Update to version 1.16.1.20250109, fix checkver & autoupdate#15977
z-Fng merged 3 commits intoScoopInstaller:masterfrom
frankclr:update-eclipse-mat

Conversation

@frankclr
Copy link
Contributor

@frankclr frankclr commented Aug 12, 2025

Homepage updated

Summary by CodeRabbit

  • Updates

    • Version bumped to 1.16.1.20250109
    • License updated to EPL-2.0
    • Homepage moved to the new eclipse.dev domain
    • Download URL and checksum updated; update/checker URLs and patterns modernized
  • New Features

    • Added JDK suggestions (OpenJDK 17 and OpenJDK) for streamlined setup

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

eclipse-mat

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@frankclr frankclr force-pushed the update-eclipse-mat branch from e6279f9 to 4b0ff15 Compare August 14, 2025 16:40
@Lutra-Fs
Copy link
Member

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

eclipse-mat

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@Lutra-Fs
Copy link
Member

You can also update the hash extraction to use the way describe in https://wiki.eclipse.org/CBI/How_to_check_integrity_of_downloads_from_the_Eclipse_Foundation

@frankclr frankclr force-pushed the update-eclipse-mat branch 2 times, most recently from 5059673 to 2e645d4 Compare August 15, 2025 11:09
@frankclr
Copy link
Contributor Author

You can also update the hash extraction to use the way describe in https://wiki.eclipse.org/CBI/How_to_check_integrity_of_downloads_from_the_Eclipse_Foundation

Yes,done it

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

Bumps Eclipse Memory Analyzer from 1.15.0.20231206 to 1.16.1.20250109, updates homepage and license, adds a JDK suggest block, and revises download URLs, checksum values, checkver/autoupdate endpoints, and regexes for SHA-512.

Changes

Cohort / File(s) Summary
Manifest Configuration Update
bucket/eclipse-mat.json
Version updated to 1.16.1.20250109; homepage changed to https://eclipse.dev/mat/; license set to EPL-2.0; added top-level suggest JDK entries (java/openjdk17, java/openjdk); updated 64-bit download URL and SHA-512 hash; revised checkver.url and checkver.regex; updated autoupdate URL patterns and hash URL/regex (SHA-512).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a bump, the manifest gleams,

From fifteen to sixteen — new download streams.
Hashes replaced, homepage anew,
JDK friends invited, ready to chew.
Memory Analyzer, refreshed and true.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The PR description is minimal and somewhat vague. While it correctly includes "Relates to #15971" which references the relevant issue, the summary "Homepage updated" is overly generic given the scope of changes, which includes version bumping (1.15.0.20231206 to 1.16.1.20250109), license updates (EPL-1.0 to EPL-2.0), URL and hash updates, checkver and autoupdate fixes, and addition of JDK suggestions. The description does not address or acknowledge the full extent of modifications beyond the homepage URL change. The PR description should be expanded to provide a more comprehensive summary of the changes made. Consider describing the version update, the license change, the fixes applied to checkver and autoupdate mechanisms, and other significant modifications beyond just the homepage update. This will help reviewers and future maintainers understand the full scope and intent of the pull request.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "eclipse-mat: Update to version 1.16.1.20250109, fix checkver & autoupdate" clearly and specifically summarizes the main changes in the pull request. It follows the conventional format of <manifest-name>: <summary>, identifies the key changes (version update, checkver and autoupdate fixes), and directly corresponds to the modifications shown in the changeset summary. The title is concise, specific, and provides meaningful context for reviewers scanning the pull request history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c2947 and 0d043b4.

📒 Files selected for processing (1)
  • bucket/eclipse-mat.json (2 hunks)
🔇 Additional comments (3)
bucket/eclipse-mat.json (3)

2-11: ✓ Version, homepage, license, and suggest block updates look good.

The version bump to 1.16.1.20250109, homepage migration to eclipse.dev, license update to EPL-2.0, and JDK suggest block (openjdk17 and openjdk) are all correctly implemented and align with the PR objectives and past review feedback.


36-38: SHA-512 hash extraction is correctly configured.

The sums.php endpoint returns a valid SHA-512 hash in the format <hash> <filename>, where the hash is 128 hexadecimal characters. The regex pattern $sha512.*?$basename correctly targets this format to extract the hash portion, and the verification confirms the endpoint returns the expected hash value.


14-38: Both checkver and autoupdate regex patterns are correct and verified to work.

The checkver regex rcp/MemoryAnalyzer-([\d.]+)-win32 correctly extracts version 1.16.1.20250109 from eclipse.dev/mat/download/. The autoupdate hash regex $sha512.*?$basename properly matches the sums.php endpoint response format, which returns the hash followed by the filename. The hash value in the JSON file matches what the endpoint provides. No issues found.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@z-Fng
Copy link
Member

z-Fng commented Oct 19, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

eclipse-mat

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng changed the title eclipse-mat: Update to version 1.16.1 eclipse-mat: Update to version 1.16.1.20250109, fix checkver & autoupdate Oct 19, 2025
@z-Fng
Copy link
Member

z-Fng commented Oct 19, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

eclipse-mat

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng merged commit 7805ffc into ScoopInstaller:master Oct 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants