Add comprehensive allocation tests for performance regression prevention#143
Open
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Open
Conversation
This PR adds a new test file (test/alloc_test.jl) that uses AllocCheck.jl to verify zero-allocation behavior for the hot paths in SymbolicIndexingInterface. After thorough benchmarking and profiling, the package was found to already be well-optimized: - Scalar getters/setters: 0 allocations (~4ns per call) - Tuple getters/setters: 0 allocations (~5ns per call) - Observed function evaluation: 0 allocations after first compilation - Index lookups: 0 allocations (~7-10ns per call) - In-place array getters: 0 allocations The new tests document and protect this performance: - Scalar getp/setp with arrays and ProblemState - Scalar getsym/setsym with arrays and ProblemState - Tuple getp/getsym - In-place array getp - Observed function (expression) evaluation - Index lookups (variable_index, parameter_index, is_variable, is_parameter) - Value provider interface functions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Should this also disable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance Analysis Results
After thorough benchmarking and profiling, the package was found to already be well-optimized:
New Allocation Tests
The new test file (
test/alloc_test.jl) covers:Test plan
cc @ChrisRackauckas
🤖 Generated with Claude Code