Qualify constructor methods in extensions#550
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Feb 9, 2026
Merged
Conversation
Adds explicit module qualification to constructor methods added in extensions, replacing `import` with `using` and qualifying constructors as `Surrogates.X(...)`. This is the recommended approach for Julia 1.12+ to avoid precompilation warnings about unqualified constructor extension. Based on PR SciML#548 by @danielwe, rebased onto current master. Co-Authored-By: Daniel Wennberg <daniel.wennberg@gmail.com> Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import Surrogates: Xwithusing Surrogates: X, Surrogatesin all extension modulesSurrogates.X(...)instead of relying on implicit method extensionContext
This is a rebase of #548 by @danielwe onto current master (which includes #549). While #549 switched from
usingtoimport(which also allows method extension), this PR uses explicit module qualification which is the approach recommended by the Julia 1.12 deprecation warning:Both approaches work, but explicit qualification is more robust and clearer in intent.
Test plan
🤖 Generated with Claude Code